Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow users to have multiple verified IPs #675

Merged
merged 2 commits into from
Oct 20, 2024
Merged

Allow users to have multiple verified IPs #675

merged 2 commits into from
Oct 20, 2024

Conversation

Beyley
Copy link
Member

@Beyley Beyley commented Oct 20, 2024

No description provided.

@Beyley Beyley requested a review from jvyden October 20, 2024 00:03
jvyden
jvyden requested changes Oct 20, 2024
View reviewed changes
Copy link
Member

@jvyden jvyden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I disagree with allowing an unlimited number of IP addresses since that can lead to a lot of authorized IPs as IPs change. Something like 2 or 3 is better, but can be addressed later.

Refresh.GameServer/Endpoints/Game/Handshake/AuthenticationEndpoints.cs Outdated Show resolved Hide resolved
@jvyden
Reword ip fail error
b119b4e 
Signed-off-by: jvyden <jvyden@jvyden.xyz>
@jvyden jvyden merged commit 52adadc into LittleBigRefresh:main Oct 20, 2024
4 checks passed
@Beyley Beyley deleted the multi-ip-auth branch October 20, 2024 03:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jvyden jvyden jvyden approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Beyley @jvyden