worked on dialogs

LiveDuo · Nov 6, 2023 · 532cab1 · 532cab1
1 parent d518922
commit 532cab1
Show file tree

Hide file tree

Showing 4 changed files with 24 additions and 6 deletions.
diff --git a/lib/client/vanilla/button.tsx b/lib/client/vanilla/button.tsx
@@ -33,10 +33,16 @@ const Dialog: React.FC<DialogProps> = ({ open, setOpen }) => {
   const [newTab, setNewTab] = useState(true)
   const [type, setType] = useState('url')
 
-  const onChange = (e: string) => {
+  const onSelectType = (e: string) => {
     setType(e.toLowerCase())
   }
 
+  const onSave = () => {
+    setOpen(false)
+
+    // TODO update dom element
+  }
+
   return (
     <DialogPrimitive.Root open={open} onOpenChange={setOpen}>
       <DialogPrimitive.Portal>
@@ -66,7 +72,7 @@ const Dialog: React.FC<DialogProps> = ({ open, setOpen }) => {
                     values={options.map((o) => capitalize(o))}
                     open={openSelect}
                     setOpen={setOpenSelect}
-                    onChange={onChange}
+                    onChange={onSelectType}
                   />
 
                   <div>
@@ -147,7 +153,7 @@ const Dialog: React.FC<DialogProps> = ({ open, setOpen }) => {
             <div className="mt-4 flex justify-end">
               <DialogPrimitive.Close
                 onClick={() => {
-                  setOpen(false)
+                  onSave()
                 }}
                 className={cx(
                   'inline-flex select-none justify-center rounded-md px-4 py-2 text-sm font-medium',

diff --git a/lib/client/vanilla/image.tsx b/lib/client/vanilla/image.tsx
@@ -32,7 +32,7 @@ const Dialog: React.FC<DialogProps> = ({ open, setOpen, selectedElement, standal
   }
 
   const onSave = async () => {
-    // TODO dom element
+    // TODO update dom element
 
     setOpen(false)
   }

diff --git a/lib/client/vanilla/link.tsx b/lib/client/vanilla/link.tsx
@@ -16,6 +16,12 @@ const Dialog: React.FC<DialogProps> = ({ open, setOpen, selectedElement }) => {
   const [link, setLink] = useState(selectedElement?.href ?? '')
   const [newTab, setNewTab] = useState(true)
 
+  const onSave = () => {
+    setOpen(false)
+
+    // TODO update dom element
+  }
+
   return (
     <DialogPrimitive.Root open={open} onOpenChange={setOpen}>
       <DialogPrimitive.Portal>
@@ -59,7 +65,7 @@ const Dialog: React.FC<DialogProps> = ({ open, setOpen, selectedElement }) => {
             <div className="mt-4 flex justify-end">
               <DialogPrimitive.Close
                 onClick={() => {
-                  setOpen(false)
+                  onSave()
                 }}
                 className={cx(
                   'inline-flex select-none justify-center rounded-md px-4 py-2 text-sm font-medium',

diff --git a/lib/client/vanilla/svg.tsx b/lib/client/vanilla/svg.tsx
@@ -15,6 +15,12 @@ type DialogProps = {
 const Dialog: React.FC<DialogProps> = ({ open, setOpen, selectedElement }) => {
   const [path, setPath] = useState('')
 
+  const onSave = () => {
+    setOpen(false)
+
+    // TODO update dom element
+  }
+
   return (
     <DialogPrimitive.Root open={open} onOpenChange={setOpen}>
       <DialogPrimitive.Portal>
@@ -49,7 +55,7 @@ const Dialog: React.FC<DialogProps> = ({ open, setOpen, selectedElement }) => {
             <div className="mt-4 flex justify-end">
               <DialogPrimitive.Close
                 onClick={() => {
-                  setOpen(false)
+                  onSave()
                 }}
                 className={cx(
                   'inline-flex select-none justify-center rounded-md px-4 py-2 text-sm font-medium',