Send Prebid Version With Every Request #33
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3link
reviewed
Jan 9, 2024
Comment on lines
92
to
94
| const packageJson = require('../../../package.json') | ||
| const version = packageJson.version | ||
| expect(server.requests[0].url).to.contain(`tv=${version}`) |
There was a problem hiding this comment.
This test can be separated from the others. That way the test scopes will be clearer.
mschuwalow
approved these changes
Jan 9, 2024
3link
reviewed
Jan 9, 2024
|
getested on the test-page |
3link
approved these changes
Jan 9, 2024
3link
reviewed
Jan 9, 2024
| @@ -134,7 +134,7 @@ | |||
| "express": "^4.15.4", | |||
| "fun-hooks": "^0.9.9", | |||
| "just-clone": "^1.0.2", | |||
| "live-connect-js": "^6.3.2" | |||
| "live-connect-js": "^6.3.4" | |||
There was a problem hiding this comment.
Unrelated, but we should talk about it soon: ^ means, when you install the dependencies, the build system will automatically check for a newer version 6.x.y. That mean when we release e.g. a new patch of LiveConnect, but do not want it to be rolled out yet, but want to test it with a limited number of users, Prebid might just run their build and the newer version will be pulled in - something that we did not intend.
|
opened a PR in Prebid repo |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CM-971