Skip to content

Commit

Permalink
adjust conf
Browse files Browse the repository at this point in the history
  • Loading branch information
mschuwalow committed Sep 19, 2023
1 parent 09496a5 commit 14a2207
Show file tree
Hide file tree
Showing 6 changed files with 287 additions and 13 deletions.
280 changes: 279 additions & 1 deletion package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 2 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -116,6 +116,7 @@
"typescript": "^5.1.6",
"url": "^0.11.1",
"wdio-chromedriver-service": "8.1.1",
"wdio-docker-service": "3.2.1"
"wdio-docker-service": "3.2.1",
"wdio-selenium-standalone-service": "^0.0.12"
}
}
10 changes: 5 additions & 5 deletions src/manager/decisions.ts
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ export function resolve(state: { pageUrl?: string, domain?: string }, storageHan
}
}

function _orElseEmtpy<A>(errorDescription: string, f: () => A[]): A[] {
function _orElseEmpty<A>(errorDescription: string, f: () => A[]): A[] {
try {
return f()
} catch (e) {
Expand All @@ -31,7 +31,7 @@ export function resolve(state: { pageUrl?: string, domain?: string }, storageHan
}
}

const freshDecisions = _orElseEmtpy(
const freshDecisions = _orElseEmpty(
'Error while extracting new decision ids',
() => {
const extractedFreshDecisions = ([] as ParsedParam[]).concat((state.pageUrl && getQueryParameter(state.pageUrl, DECISION_ID_QUERY_PARAM_NAME)) || [])
Expand All @@ -43,14 +43,14 @@ export function resolve(state: { pageUrl?: string, domain?: string }, storageHan
}
)

const storedDecisions = _orElseEmtpy(
const storedDecisions = _orElseEmpty(
'Error while retrieving stored decision ids',
() => {
const extractedStoredDecisions = storageHandler.findSimilarCookies(DECISION_ID_COOKIE_NAMESPACE)
return extractedStoredDecisions.map(trim)
return extractedStoredDecisions
.map(trim)
.filter(_nonEmpty)
.filter(isUUID)
.filter(_onlyUnique)
}
)

Expand Down
3 changes: 1 addition & 2 deletions src/standard-live-connect.ts
Original file line number Diff line number Diff line change
Expand Up @@ -130,8 +130,7 @@ function _standardInitialization (liveConnectConfig: LiveConnectConfig, external
resolutionCallUrl: resolver.getUrl.bind(resolver),
config: validLiveConnectConfig,
eventBus: eventBus,
storageHandler: enrichedState.storageHandler,
callHandler: enrichedState.callHandler,
storageHandler: enrichedState.storageHandler
}
} catch (x) {
console.error(x)
Expand Down
1 change: 0 additions & 1 deletion src/types.ts
Original file line number Diff line number Diff line change
Expand Up @@ -108,6 +108,5 @@ export interface ILiveConnect {
peopleVerifiedId?: string
config: LiveConnectConfig
eventBus?: EventBus,
callHandler?: WrappedCallHandler,
storageHandler?: WrappedStorageHandler,
}
3 changes: 0 additions & 3 deletions test-config/wdio.local.chrome.conf.mjs
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,6 @@ import common from './wdio.common.conf.mjs'

export const config = {
...common('local'),
hostname: 'localhost',
port: 4444,
path: '/wd/hub',

//
// If you have trouble getting all important capabilities together, check out the
Expand Down

0 comments on commit 14a2207

Please sign in to comment.