[No Ticket] Cleanup pass and enable strict mode #103
Conversation
| const successCallback = (responseAsJson) => { | ||
| expect(callCount).to.be.eql(1) | ||
| expect(errors).to.be.empty() | ||
| expect(responseAsJson).to.be.eql(response) | ||
| expect(requestToComplete.url).to.eq('https://idx.liadm.com/idex/unknown/any') | ||
| expect(responseAsJson).to.be.eql(response) | ||
| expect(callCount).to.be.eql(1) | ||
| expect(storageHandler.getCookie('__li_idex_cache')).to.be.eq(JSON.stringify(response)) | ||
| expect(storageHandler.getCookie('__li_idex_cache_e30')).to.be.eq(JSON.stringify(response)) |
There was a problem hiding this comment.
The cache key for no provided additional parameters changed. (As we are using {} instead of undefined)
I don't think this is a problem as we will just re-resolve, but I can revert this change if desired
| const successCallback = (responseAsJson) => { | ||
| expect(callCount).to.be.eql(1) | ||
| expect(errors).to.be.empty() | ||
| expect(responseAsJson).to.be.eql(response) | ||
| expect(requestToComplete.url).to.eq('https://idx.liadm.com/idex/unknown/any') | ||
| expect(responseAsJson).to.be.eql(response) | ||
| expect(callCount).to.be.eql(1) | ||
| expect(storageHandler.getCookie('__li_idex_cache')).to.be.eq(JSON.stringify(response)) | ||
| expect(storageHandler.getCookie('__li_idex_cache_e30')).to.be.eq(JSON.stringify(response)) |
|
Have to do a second pass. The PR is too large for one pass. |
| stackTrace: _truncate(e.stack), | ||
| lineNumber: _asInt(e.lineNumber), | ||
| lineColumn: _asInt(e.lineColumn), | ||
| columnNumber: _asInt(e.columnNumber), |
| interface WrappedExternalCallHandler { | ||
| ajaxGet: ( | ||
| url: string, | ||
| onSuccess: (responseText: string, response: unknown) => void, |
There was a problem hiding this comment.
| onSuccess: (responseText: string, response: unknown) => void, | |
| onSuccess: (responseText: string, response ?: unknown) => void, |
There was a problem hiding this comment.
no need, the callback will always be provided with the argument
There was a problem hiding this comment.
but when it is called it uses only the first param
https://github.com/LiveIntent/live-connect/blob/master/src/pixel/sender.ts#L57
There was a problem hiding this comment.
Using only one is fine. The questionmark would signal that the function is only provided 1 argument sometimes, even if it asks for 2.
Short description if any.
Author Todo List:
Ready For Reviewstatus