[CM-944] Expose internal interfaces #203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3link
reviewed
Oct 6, 2023
src/types.ts
Outdated
Comment on lines
99
to
101
| export interface PublicLiveConnect { | ||
| push: (...event: unknown[]) => void | ||
| } |
There was a problem hiding this comment.
Would it make sense to make the resolve function and config part of the public interface?
There was a problem hiding this comment.
Resolve yes, I would say config is probably not something users should use
SuperIzya
reviewed
Oct 6, 2023
src/types.ts
Outdated
Comment on lines
99
to
101
| export interface PublicLiveConnect { | ||
| push: (...event: unknown[]) => void | ||
| } |
SuperIzya
approved these changes
Oct 6, 2023
wi101
approved these changes
Oct 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CM-944
Short description if any.
Author Todo List:
Ready For Reviewstatus