[CM-1090] Allow resolving idcookie #304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3link
approved these changes
Jan 12, 2024
| this.timeout | ||
| ) | ||
| private buildUrl(params: [string, string][]): string { | ||
| return `${this.url}/${this.source}/${this.publisherId}${toParams(this.filterParams(params))}` | ||
| } | ||
|
|
||
| getUrl(additionalParams: Record<string, string | string[]>): string { |
There was a problem hiding this comment.
Any idea why we expose the resolutionCallUrl in LiveConnect at all getUrl is used to compute resolutionCallUrl?
There was a problem hiding this comment.
No idea. As you say, it's just an alias for getUrl resolutionCallUrl: resolver.getUrl.bind(resolver),
Comment on lines
+318
to
+328
| it('should resolve the idcookie when requested via additional attributes', (done) => { | ||
| const value = 'foo' | ||
| const identityResolver = new IdentityResolver({ resolvedIdCookie: value }, calls) | ||
| const successCallback = (responseAsJson) => { | ||
| expect(requestToComplete.url).to.eq('https://idx.liadm.com/idex/unknown/any') | ||
| expect(errors).to.be.empty() | ||
| expect(responseAsJson).to.be.eql({ idcookie: value }) | ||
| done() | ||
| } | ||
| identityResolver.resolve(successCallback, () => {}, { resolve: ['idcookie'] }) | ||
| requestToComplete.respond(200, { 'Content-Type': 'application/json' }, JSON.stringify({})) |
wi101
reviewed
Jan 15, 2024
| return state => { | ||
| let resolvedIdCookie: string | null | ||
|
|
||
| if (state.idCookie?.mode === 'provided' && state.idCookie?.strategy === 'cookie' && typeof state.idCookie?.name === 'string') { |
There was a problem hiding this comment.
We can make 'generated', 'provided', 'cookie', 'localStorage' constants and use them, WDYT
There was a problem hiding this comment.
Not really any benefit when using typescript. It is already typed as "provided" | "generated" and will complain if you try to compare it to any other string
peixunzhang
approved these changes
Jan 15, 2024
wi101
approved these changes
Jan 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CM-1090
Author Todo List:
Ready For Reviewstatus