Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Poetry config #51

Merged
merged 30 commits into from
Nov 29, 2022
Merged

Poetry config #51

merged 30 commits into from
Nov 29, 2022

Conversation

griff-rees
Copy link
Collaborator

Hi @LydiaFrance and @andrewphilipsmith. I haven't reached all the goals for version 0.3.4, and the only tickets addressed so far are

but I figured getting your thoughts on how far I've gotten (have a look at CHANGELOG.md, but can highlight stuff here as well if you like).

If you'd also rather only merge to main when all changes for 3.4 are achieved no worries, can create further branches for those changes but figured this might be a helpful start to review how it's going.

@griff-rees
Copy link
Collaborator Author

Looks like I need to alter everything to python>=3.7, will update you on that when it's ready.

@LydiaFrance
Copy link
Collaborator

LydiaFrance commented Jul 27, 2022

From an AAAH perspective important that the walkthroughs/demos with the dummy files work. I tried running the demo in the documentation (see demo.md) and those instructions are out of date.

  • pip install alto2txt needs to replace pip install -r requirements.txt
  • the directory tree for ./extract_publications_text.py -p single demo-files demo-output needs to be changed to src/alto2txt/extract_publications_text.py

@griff-rees
Copy link
Collaborator Author

Hey @LydiaFrance: thanks for the comments. I'm hoping my recent commits addresses that, another review would be great.

@griff-rees griff-rees added documentation Improvements or additions to documentation enhancement New feature or request labels Nov 17, 2022
Copy link
Collaborator

@LydiaFrance LydiaFrance left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks good!

@griff-rees griff-rees merged commit 34f9433 into main Nov 29, 2022
@griff-rees griff-rees deleted the poetry-config branch November 29, 2022 15:43
@griff-rees griff-rees self-assigned this Nov 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants