Skip to content

Commit

Permalink
Fix invalid parameter passed to WSASendMsg()
Browse files Browse the repository at this point in the history
The second parameter is for flags, not number of messages.
  • Loading branch information
cgutman committed Jul 19, 2024
1 parent 3935d30 commit f2768d5
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions src/platform/windows/misc.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -1537,7 +1537,7 @@ namespace platf {

// If USO is not supported, this will fail and the caller will fall back to unbatched sends.
DWORD bytes_sent;
return WSASendMsg((SOCKET) send_info.native_socket, &msg, 1, &bytes_sent, nullptr, nullptr) != SOCKET_ERROR;
return WSASendMsg((SOCKET) send_info.native_socket, &msg, 0, &bytes_sent, nullptr, nullptr) != SOCKET_ERROR;

Check warning on line 1540 in src/platform/windows/misc.cpp

View check run for this annotation

Codecov / codecov/patch

src/platform/windows/misc.cpp#L1540

Added line #L1540 was not covered by tests
}

bool
Expand Down Expand Up @@ -1614,7 +1614,7 @@ namespace platf {
msg.Control.len = cmbuflen;

DWORD bytes_sent;
if (WSASendMsg((SOCKET) send_info.native_socket, &msg, 1, &bytes_sent, nullptr, nullptr) == SOCKET_ERROR) {
if (WSASendMsg((SOCKET) send_info.native_socket, &msg, 0, &bytes_sent, nullptr, nullptr) == SOCKET_ERROR) {
auto winerr = WSAGetLastError();
BOOST_LOG(warning) << "WSASendMsg() failed: "sv << winerr;
return false;
Expand Down

0 comments on commit f2768d5

Please sign in to comment.