-
-
Notifications
You must be signed in to change notification settings - Fork 950
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add min_fps_target setting #1043
Conversation
efc275f
to
ad20ac1
Compare
0867994
to
900655e
Compare
900655e
to
6721fe4
Compare
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as resolved.
This comment was marked as resolved.
6721fe4
to
0870c09
Compare
0870c09
to
af76a8a
Compare
This is working now. I was missing the part where it reads the config option from the saved config file so it was always using the default value. I also renamed the setting to For me, if I set the value to 1 FPS, my stream is about 7-8 FPS (according to Moonlight) with static content. If I set to 240 FPS, I get about 65-68 FPS. I only tested on my laptop with integrated AMD graphics, with all other options as default. |
This comment was marked as resolved.
This comment was marked as resolved.
854a8a2
to
acb1750
Compare
acb1750
to
84ae8a9
Compare
This comment was marked as off-topic.
This comment was marked as off-topic.
@cgutman do you think this PR should be resumed? I know there's been a lot of activity to try to improve streaming performance, and I don't know if this is still relevant. |
This change seems to improve slightly the number of microstutters when switching from a static image to an active one and back. Needs further testing / changes. |
84ae8a9
to
369dcff
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1043 +/- ##
=========================================
- Coverage 8.97% 8.96% -0.01%
=========================================
Files 94 94
Lines 17389 17392 +3
Branches 8267 8270 +3
=========================================
Hits 1560 1560
Misses 12967 12967
- Partials 2862 2865 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
|
d3a4f39
to
18b0b3c
Compare
18b0b3c
to
f651fc9
Compare
Description
Add minimum fps target setting to help in situations where 10 fps is too low.
Screenshot
Issues Fixed or Closed
Type of Change
.github/...
)Checklist
Branch Updates
LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.