Use nlohmann_json package instead of submodule

[chewi]

Description

As requested in #2148.

Type of Change

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• Dependency update (updates to dependencies)
• Documentation update (changes to documentation)
• Repository update (changes to repository files, e.g. .github/...)

Checklist

• My code follows the style guidelines of this project
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

Branch Updates

LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.

• I want maintainers to keep my branch updated

[ReenigneArcher]

Thank you!

At first glance it looks like you updated everything except packaging/macos/Portfile

[chewi]

Okay, fixed!

[chewi]

Some failures. I think I've fixed Flatpak and Windows. I don't know why MacPorts failed, the error looks unrelated.

The AppImage failed because sadly the Ubuntu 20.04 package lacks the .pc file. The 22.04 package has it, so we could bump the AppImage distro. That won't help people manually building on 20.04 though. I know you've said that 20.04 is EOL in 2030 but that is paid support. I doubt anyone is going to pay to use an old Ubuntu just to run this. Otherwise support ends in just over a year's time.

[chewi]

If you really wanted, I could add a generic fallback for when the .pc file isn't found.

[cgutman]

The AppImage failed because sadly the Ubuntu 20.04 package lacks the .pc file. The 22.04 package has it, so we could bump the AppImage distro. That won't help people manually building on 20.04 though. I know you've said that 20.04 is EOL in 2030 but that is paid support. I doubt anyone is going to pay to use an old Ubuntu just to run this. Otherwise support ends in just over a year's time.

We can't switch the AppImage to Ubuntu 22.04 yet. AppImages are bound to run on a glibc equal or greater than the version they were built against. In addition to the AppImage tooling itself preventing building with a glibc version that new, it would break commonly used distros like Debian Bullseye which ship with an older glibc than Ubuntu 22.04.

[chewi]

I thought AppImage might use its own glibc, but I know that's not straightforward. Steam doesn't for the same reason.

It doesn't matter though. I just realised you only use nlohmann_json on Windows. 😂

[ReenigneArcher]

It doesn't matter though. I just realised you only use nlohmann_json on Windows. 😂

What? 😂

[chewi]

If you have any doubts, trigger the pipeline and find out. 😁