Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(linux): refactor linux build #2275

Merged
merged 2 commits into from
Mar 17, 2024
Merged

Conversation

ReenigneArcher
Copy link
Member

@ReenigneArcher ReenigneArcher commented Mar 17, 2024

Description

Attempt to improve AppImage build, and hopefully resolve runner out of space and/or memory issues.

  • Moves CUDA install to the very beginning (after installing wget)
  • Changes install directory of CUDA
  • Deletes CUDA after AppImage is packaged
  • Reduces -j arg of make command from 4 to 3
  • Removes legacy Ubuntu 18.04 logic

I attempted to bump GCC from 10 to 11, but this introduced new warnings, and errors in the AppImage lint step. This might provide a hint for the existing warnings?

w/ GCC-11

appimagelint.cli[12510] [INFO] Checking AppImage ./artifacts/sunshine.AppImage
appimagelint.cli[12510] [INFO] Running check "GNU libc ABI check"
appimagelint.glibc_abi_check[12510] [INFO] detected required version for runtime: 2.14
appimagelint.glibc_abi_check[12510] [INFO] detected required version for payload: 2.30
appimagelint.cache[12510] [INFO] Fetching glibc version data for debian
appimagelint.setup[12510] [INFO] Fetching glibc package versions from Debian sources API
Warning: int.glibc_abi_check[12510] [WARNING] could not find version for oldstable, trying backports
Error: elint.glibc_abi_check[12510] [ERROR] could not find version for oldstable in backports either, aborting check
appimagelint.glibc_abi_check[12510] [INFO] [✖] AppImage can run on Debian oldstable (bullseye)
appimagelint.glibc_abi_check[12510] [INFO] [✔] AppImage can run on Debian stable (bookworm)
Warning: int.glibc_abi_check[12510] [WARNING] could not find version for testing, trying backports
Error: elint.glibc_abi_check[12510] [ERROR] could not find version for testing in backports either, aborting check
appimagelint.glibc_abi_check[12510] [INFO] [✖] AppImage can run on Debian testing (trixie)
appimagelint.glibc_abi_check[12510] [INFO] [✔] AppImage can run on Debian unstable (sid)
appimagelint.cache[12510] [INFO] Fetching glibc version data for ubuntu
appimagelint.setup[12510] [INFO] Fetching glibc package versions from Ubuntu FTP mirror
appimagelint.glibc_abi_check[12510] [INFO] [✔] AppImage can run on Ubuntu mantic
appimagelint.glibc_abi_check[12510] [INFO] [✔] AppImage can run on Ubuntu jammy
appimagelint.glibc_abi_check[12510] [INFO] [✔] AppImage can run on Ubuntu focal
appimagelint.glibc_abi_check[12510] [INFO] [✖] AppImage can run on Ubuntu bionic
appimagelint.glibc_abi_check[12510] [INFO] [✖] AppImage can run on Ubuntu xenial
appimagelint.glibc_abi_check[12510] [INFO] [✖] AppImage can run on Ubuntu trusty
appimagelint.cache[12510] [INFO] Fetching glibc version data for centos
appimagelint.setup[12510] [INFO] Fetching glibc package versions from CentOS mirror
appimagelint.glibc_abi_check[12510] [INFO] [✖] AppImage can run on CentOS 7
appimagelint.cli[12510] [INFO] Running check "GNU libstdc++ ABI check"
appimagelint.glibcxx_abi_check[12510] [INFO] detected required version for runtime: <none>
appimagelint.glibcxx_abi_check[12510] [INFO] detected required version for payload: 3.4.30
appimagelint.cache[12510] [INFO] Fetching glibcxx version data for debian
Warning: int.gnu_lib_versions_symbols_finder[12510] [WARNING] no binaries found in /dev/shm/appimagelint-zxhotuxn.tmp/out/
Warning: int.gnu_lib_versions_symbols_finder[12510] [WARNING] no binaries found in /dev/shm/appimagelint-0eny1src.tmp/out/
Warning: int.gnu_lib_versions_symbols_finder[12510] [WARNING] no binaries found in /dev/shm/appimagelint-aa6lx2su.tmp/out/
Warning: int.gnu_lib_versions_symbols_finder[12510] [WARNING] no binaries found in /dev/shm/appimagelint-42eubsdd.tmp/out/
appimagelint.glibcxx_abi_check[12510] [INFO] [✖] AppImage can run on Debian oldstable (bullseye)
appimagelint.glibcxx_abi_check[12510] [INFO] [✖] AppImage can run on Debian stable (bookworm)
appimagelint.glibcxx_abi_check[12510] [INFO] [✖] AppImage can run on Debian testing (trixie)
appimagelint.glibcxx_abi_check[12510] [INFO] [✖] AppImage can run on Debian unstable (sid)
appimagelint.cache[12510] [INFO] Fetching glibcxx version data for ubuntu
Warning: int.gnu_lib_versions_symbols_finder[12510] [WARNING] no binaries found in /dev/shm/appimagelint-i7jrb6c1.tmp/out/
Warning: int.gnu_lib_versions_symbols_finder[12510] [WARNING] no binaries found in /dev/shm/appimagelint-ruvtunsb.tmp/out/
Warning: int.gnu_lib_versions_symbols_finder[12510] [WARNING] no binaries found in /dev/shm/appimagelint-ccv2uqru.tmp/out/
Warning: int.gnu_lib_versions_symbols_finder[12510] [WARNING] no binaries found in /dev/shm/appimagelint-edu6w5_c.tmp/out/
Warning: int.gnu_lib_versions_symbols_finder[12510] [WARNING] no binaries found in /dev/shm/appimagelint-d5vjavkt.tmp/out/
Warning: int.gnu_lib_versions_symbols_finder[12510] [WARNING] no binaries found in /dev/shm/appimagelint-3swzt79h.tmp/out/
appimagelint.glibcxx_abi_check[12510] [INFO] [✔] AppImage can run on Ubuntu mantic
appimagelint.glibcxx_abi_check[12510] [INFO] [✔] AppImage can run on Ubuntu jammy
appimagelint.glibcxx_abi_check[12510] [INFO] [✖] AppImage can run on Ubuntu focal
appimagelint.glibcxx_abi_check[12510] [INFO] [✖] AppImage can run on Ubuntu bionic
appimagelint.glibcxx_abi_check[12510] [INFO] [✖] AppImage can run on Ubuntu xenial
appimagelint.glibcxx_abi_check[12510] [INFO] [✖] AppImage can run on Ubuntu trusty
appimagelint.cache[12510] [INFO] Fetching glibcxx version data for centos
appimagelint.setup[12510] [INFO] Fetching libstdc++ package versions from CentOS mirror
appimagelint.glibcxx_abi_check[12510] [INFO] [✖] AppImage can run on CentOS 7
appimagelint.cli[12510] [INFO] Running check "Icons validity and location check"
appimagelint.icons_check[12510] [INFO] Extracting icon name from desktop file: /tmp/.mount_sunshi86qHCh/sunshine.desktop
appimagelint.icons_check[12510] [INFO] Checking resolution of icon: /tmp/.mount_sunshi86qHCh/sunshine.svg
appimagelint.icons_check[12510] [INFO] [✔] Valid icon in AppDir root
appimagelint.icons_check[12510] [INFO] Checking resolution of icon: /tmp/.mount_sunshi86qHCh/.DirIcon
appimagelint.icons_check[12510] [INFO] [✔] Valid icon file in .DirIcon
appimagelint.icons_check[12510] [INFO] Checking resolution of icon: /tmp/.mount_sunshi86qHCh/usr/share/icons/hicolor/256x256/apps/sunshine.png
appimagelint.icons_check[12510] [INFO] Checking resolution of icon: /tmp/.mount_sunshi86qHCh/usr/share/icons/hicolor/scalable/apps/sunshine.svg
Warning: int.icons_check[12510] [WARNING] Icon found whose file name doesn't match the Icon= entry in desktop file: hicolor/scalable/status/sunshine-locked.svg
Warning: int.icons_check[12510] [WARNING] Icon found whose file name doesn't match the Icon= entry in desktop file: hicolor/scalable/status/sunshine-pausing.svg
Warning: int.icons_check[12510] [WARNING] Icon found whose file name doesn't match the Icon= entry in desktop file: hicolor/scalable/status/sunshine-playing.svg
Warning: int.icons_check[12510] [WARNING] Icon found whose file name doesn't match the Icon= entry in desktop file: hicolor/scalable/status/sunshine-tray.svg
appimagelint.icons_check[12510] [INFO] [✔] Other integration icons valid
appimagelint.cli[12510] [INFO] Running check "Desktop files existence and validity"
appimagelint.desktop_files[12510] [INFO] Checking desktop files in root directory
appimagelint.desktop_files[12510] [INFO] [✔] Exactly one desktop file in AppDir root
appimagelint.desktop_files[12510] [INFO] Checking desktop file /tmp/.mount_sunshi8ugNZL/sunshine.desktop with desktop-file-validate
/tmp/.mount_sunshi8ugNZL/sunshine.desktop: hint: value "AudioVideo;Network;RemoteAccess;" for key "Categories" in group "Desktop Entry" contains more than one main category; application might appear more than once in the application menu
appimagelint.desktop_files[12510] [INFO] Checking desktop file /tmp/.mount_sunshi8ugNZL/usr/share/applications/sunshine.desktop with desktop-file-validate
/tmp/.mount_sunshi8ugNZL/usr/share/applications/sunshine.desktop: hint: value "AudioVideo;Network;RemoteAccess;" for key "Categories" in group "Desktop Entry" contains more than one main category; application might appear more than once in the application menu
appimagelint.desktop_files[12510] [INFO] [✔] All desktop files in AppDir are valid

Screenshot

Issues Fixed or Closed

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update (updates to dependencies)
  • Documentation update (changes to documentation)
  • Repository update (changes to repository files, e.g. .github/...)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

Branch Updates

LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.

  • I want maintainers to keep my branch updated

@ReenigneArcher ReenigneArcher force-pushed the ci(linux)-refactor-linux-build branch 2 times, most recently from d3cbe39 to 3d0ae5c Compare March 17, 2024 03:07
@ReenigneArcher ReenigneArcher merged commit 8316f44 into nightly Mar 17, 2024
49 checks passed
@ReenigneArcher ReenigneArcher deleted the ci(linux)-refactor-linux-build branch March 17, 2024 04:07
KuleRucket pushed a commit to KuleRucket/Sunshine that referenced this pull request Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant