Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(linux/x11): use config value for output_name #2294

Conversation

ReenigneArcher
Copy link
Member

Description

When developing encoder fixtures for #1603, I noticed that X11 capture looks for the DISPLAY environment variable instead of using the config value.

I think if we got the value from the config it would make it so users don't have to set an ENV variable when trying to start Sunshine via SSH.

This is completely untested, so just leaving this here for anyone who wants to test.

Screenshot

Issues Fixed or Closed

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update (updates to dependencies)
  • Documentation update (changes to documentation)
  • Repository update (changes to repository files, e.g. .github/...)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

Branch Updates

LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.

  • I want maintainers to keep my branch updated

@ReenigneArcher ReenigneArcher mentioned this pull request Mar 24, 2024
20 tasks
@cgutman
Copy link
Collaborator

cgutman commented Mar 30, 2024

I think the existing code is correct. The X11 "Display" is not really a display in true sense - it is more of a generic abstraction. We do use output name during the actual enumeration of the individual monitors to select the right one to stream.

@ReenigneArcher ReenigneArcher deleted the fix(linux/x11)-use-config-value-for-output_name branch March 30, 2024 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants