Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): could not submit pin due to localization updates #2324

Conversation

ReenigneArcher
Copy link
Member

Description

After localization updates, the pin page was rendered without the js that was responsible for sending the pin the backend.

Screenshot

Issues Fixed or Closed

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update (updates to dependencies)
  • Documentation update (changes to documentation)
  • Repository update (changes to repository files, e.g. .github/...)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

Branch Updates

LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.

  • I want maintainers to keep my branch updated

Copy link

codecov bot commented Mar 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 6.10%. Comparing base (2b059c6) to head (3627232).

Additional details and impacted files
@@           Coverage Diff           @@
##           nightly   #2324   +/-   ##
=======================================
  Coverage     6.10%   6.10%           
=======================================
  Files           85      85           
  Lines        18303   18303           
  Branches      8319    8319           
=======================================
  Hits          1118    1118           
  Misses       15376   15376           
  Partials      1809    1809           
Flag Coverage Δ
Linux 4.11% <ø> (ø)
Windows 1.51% <ø> (ø)
macOS-12 8.11% <ø> (ø)
macOS-13 7.41% <ø> (-0.05%) ⬇️
macOS-14 7.72% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@ReenigneArcher ReenigneArcher marked this pull request as draft March 29, 2024 20:10
@ReenigneArcher
Copy link
Member Author

@TheElixZammuto this still doesn't pair a device. Do you have some idea?

@TheElixZammuto
Copy link
Contributor

@ReenigneArcher the commit should fix this. the event listeners were initalized before the page actually loaded

@ReenigneArcher ReenigneArcher force-pushed the fix(ui)-could-not-submit-pin-due-to-localization-updates branch 2 times, most recently from e0034af to 4716988 Compare March 30, 2024 14:12
@ReenigneArcher ReenigneArcher force-pushed the fix(ui)-could-not-submit-pin-due-to-localization-updates branch from 4716988 to 3627232 Compare March 30, 2024 14:42
@ReenigneArcher ReenigneArcher marked this pull request as ready for review March 30, 2024 14:59
@ReenigneArcher ReenigneArcher merged commit 376a282 into nightly Mar 30, 2024
51 checks passed
@ReenigneArcher ReenigneArcher deleted the fix(ui)-could-not-submit-pin-due-to-localization-updates branch March 30, 2024 15:35
KuleRucket pushed a commit to KuleRucket/Sunshine that referenced this pull request Jun 6, 2024
…#2324)

Co-authored-by: Elia Zammuto <theelixzammuto@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants