Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: update codeql to handle multiple OSes #2425

Merged
merged 1 commit into from
Apr 16, 2024

Conversation

ReenigneArcher
Copy link
Member

@ReenigneArcher ReenigneArcher commented Apr 16, 2024

Description

Updates codeql to run in a matrix for cpp analysis. This is required in order to analyze any code that is os specific.

See: LizardByte/.github#322

Screenshot

Issues Fixed or Closed

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update (updates to dependencies)
  • Documentation update (changes to documentation)
  • Repository update (changes to repository files, e.g. .github/...)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

Branch Updates

LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.

  • I want maintainers to keep my branch updated

@ReenigneArcher ReenigneArcher force-pushed the ci-update-codeql-to-handle-multiple-OSes branch 2 times, most recently from f209b39 to 9ac63f0 Compare April 16, 2024 02:35
Copy link

codecov bot commented Apr 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 6.77%. Comparing base (76d08eb) to head (1c45318).

Additional details and impacted files
@@           Coverage Diff           @@
##           nightly   #2425   +/-   ##
=======================================
  Coverage     6.77%   6.77%           
=======================================
  Files           86      86           
  Lines        17523   17523           
  Branches      8088    8091    +3     
=======================================
  Hits          1187    1187           
+ Misses       14664   14662    -2     
- Partials      1672    1674    +2     
Flag Coverage Δ
Linux 5.75% <ø> (ø)
Windows 2.04% <ø> (ø)
macOS-12 8.57% <ø> (-0.02%) ⬇️
macOS-13 ?
macOS-14 8.11% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 4 files with indirect coverage changes

@ReenigneArcher ReenigneArcher force-pushed the ci-update-codeql-to-handle-multiple-OSes branch 4 times, most recently from 69b2b28 to 321957e Compare April 16, 2024 21:12
@ReenigneArcher ReenigneArcher force-pushed the ci-update-codeql-to-handle-multiple-OSes branch from 321957e to 1c45318 Compare April 16, 2024 21:14
@ReenigneArcher ReenigneArcher marked this pull request as ready for review April 16, 2024 21:31
@ReenigneArcher ReenigneArcher merged commit 5db8af8 into nightly Apr 16, 2024
52 of 53 checks passed
@ReenigneArcher ReenigneArcher deleted the ci-update-codeql-to-handle-multiple-OSes branch April 16, 2024 21:41
KuleRucket pushed a commit to KuleRucket/Sunshine that referenced this pull request Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant