-
-
Notifications
You must be signed in to change notification settings - Fork 950
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(macos/capture): support for capture display other than main display #2449
Conversation
…nitor to capture.
…product name corresponds to its display id)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the PR! I have a few suggestions below.
Now, the format for detecting displays in the startup logs is consistent between macOS and Linux. However, it appears that the id counting differs between the Linux and macOS, macOS doesn't count the display from zero, but this shouldn't cause any significant issues. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! I just noticed two minor spacing issues in the docs. Once that is resolved, I think this is ready to merge.
@ReenigneArcher all done |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## nightly #2449 +/- ##
==========================================
+ Coverage 6.16% 6.17% +0.01%
==========================================
Files 86 86
Lines 17523 17542 +19
Branches 8169 8179 +10
==========================================
+ Hits 1080 1083 +3
+ Misses 15410 15362 -48
- Partials 1033 1097 +64
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Description
Now we can use output_name properly in video config to capture a specific display in macOS.
Screenshot
Issues Fixed or Closed
Type of Change
.github/...
)Checklist
Branch Updates
LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.