Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(macos): skip link of nonexistent directories #2526

Merged

Conversation

ReenigneArcher
Copy link
Member

Description

Modify cmake to only link_directories that exist on macOS. This will remove "warnings" from the cmake logs.

Screenshot

Issues Fixed or Closed

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update (updates to dependencies)
  • Documentation update (changes to documentation)
  • Repository update (changes to repository files, e.g. .github/...)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

Branch Updates

LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.

  • I want maintainers to keep my branch updated

@ReenigneArcher ReenigneArcher requested a review from Hazer May 13, 2024 02:20
Copy link

codecov bot commented May 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 6.94%. Comparing base (9c5239c) to head (070963a).

Additional details and impacted files
@@            Coverage Diff            @@
##           nightly   #2526     +/-   ##
=========================================
  Coverage     6.94%   6.94%             
=========================================
  Files           87      87             
  Lines        17673   17673             
  Branches      8399    8399             
=========================================
  Hits          1227    1227             
- Misses       13749   15766   +2017     
+ Partials      2697     680   -2017     
Flag Coverage Δ
Linux 5.34% <ø> (ø)
Windows 2.56% <ø> (ø)
macOS-14 8.24% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 29 files with indirect coverage changes

@ReenigneArcher ReenigneArcher force-pushed the build(macos)-skip-link-of-nonexistent-directories branch from 814f0bc to ccb8d02 Compare May 13, 2024 12:57
@ReenigneArcher ReenigneArcher force-pushed the build(macos)-skip-link-of-nonexistent-directories branch from ccb8d02 to 070963a Compare May 13, 2024 14:07
@ReenigneArcher ReenigneArcher merged commit 81c2ecf into nightly May 13, 2024
49 of 53 checks passed
@ReenigneArcher ReenigneArcher deleted the build(macos)-skip-link-of-nonexistent-directories branch May 13, 2024 14:53
KuleRucket pushed a commit to KuleRucket/Sunshine that referenced this pull request Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants