Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix log message for Periodic Ping #2538

Merged
merged 1 commit into from
May 19, 2024

Conversation

c3m3gyanesh
Copy link
Contributor

@c3m3gyanesh c3m3gyanesh commented May 17, 2024

Description

Currently the log message for Periodic Ping displays wrong packet type. This change fix the log message to show correct packet type.

Issues Fixed or Closed

Fix bug: 2537

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update (updates to dependencies)
  • Documentation update (changes to documentation)
  • Repository update (changes to repository files, e.g. .github/...)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

Branch Updates

  • I want maintainers to keep my branch updated

@CLAassistant
Copy link

CLAassistant commented May 17, 2024

CLA assistant check
All committers have signed the CLA.

Copy link

codecov bot commented May 19, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 7.00%. Comparing base (373390e) to head (d92756a).

Files Patch % Lines
src/stream.cpp 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           nightly   #2538      +/-   ##
==========================================
- Coverage     7.04%   7.00%   -0.04%     
==========================================
  Files           87      87              
  Lines        17697   17691       -6     
  Branches      8405    8405              
==========================================
- Hits          1246    1240       -6     
+ Misses       13810   13716      -94     
- Partials      2641    2735      +94     
Flag Coverage Δ
Linux 5.35% <0.00%> (ø)
Windows 2.56% <0.00%> (ø)
macOS-12 ?
macOS-13 7.98% <0.00%> (-0.02%) ⬇️
macOS-14 8.28% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/stream.cpp 0.91% <0.00%> (ø)

... and 23 files with indirect coverage changes

@ReenigneArcher ReenigneArcher merged commit fdb443a into LizardByte:nightly May 19, 2024
52 of 53 checks passed
KuleRucket pushed a commit to KuleRucket/Sunshine that referenced this pull request Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants