-
-
Notifications
You must be signed in to change notification settings - Fork 950
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: use prerelease logic #2553
Merged
Merged
ci: use prerelease logic #2553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ReenigneArcher
force-pushed
the
ci-use-prerelease-logic
branch
2 times, most recently
from
May 22, 2024 18:25
c840693
to
a38d48e
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2553 +/- ##
=========================================
- Coverage 7.04% 7.03% -0.01%
=========================================
Files 87 87
Lines 17697 17697
Branches 8405 8406 +1
=========================================
- Hits 1246 1245 -1
Misses 13712 13712
- Partials 2739 2740 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
ReenigneArcher
force-pushed
the
ci-use-prerelease-logic
branch
6 times, most recently
from
May 22, 2024 22:33
9f38c8f
to
15a275e
Compare
11 tasks
ReenigneArcher
force-pushed
the
ci-use-prerelease-logic
branch
from
May 22, 2024 22:50
15a275e
to
6553d86
Compare
Hazer
suggested changes
May 23, 2024
ReenigneArcher
force-pushed
the
ci-use-prerelease-logic
branch
from
May 23, 2024 02:42
6553d86
to
62def5b
Compare
ReenigneArcher
commented
May 23, 2024
ReenigneArcher
force-pushed
the
ci-use-prerelease-logic
branch
from
May 23, 2024 13:51
62def5b
to
d924539
Compare
Hazer
suggested changes
May 23, 2024
ReenigneArcher
force-pushed
the
ci-use-prerelease-logic
branch
3 times, most recently
from
May 24, 2024 00:21
7f747a2
to
2ffd470
Compare
ReenigneArcher
force-pushed
the
ci-use-prerelease-logic
branch
from
May 24, 2024 01:01
2ffd470
to
97a9825
Compare
KuleRucket
pushed a commit
to KuleRucket/Sunshine
that referenced
this pull request
Jun 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Todo:
Testing version check UI:
Faked a build at v0.23.1 (current latest):
Faked a build at v0.23.0 (outdated):
Cannot really test when a pre-release is available, without creating one or two. Should work though as it's the same logic. Might have to fix forward if anything comes up.
Screenshot
Issues Fixed or Closed
Type of Change
.github/...
)Checklist
Branch Updates
LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.