Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): ensure pre-releases are properly checked #2564

Merged

Conversation

ReenigneArcher
Copy link
Member

@ReenigneArcher ReenigneArcher commented May 24, 2024

Description

  • Compare each part of release versions
  • Fix undefined variable
  • Add info message when using a pre-release instead of stable
  • CI fixes for if branch names contain parenthesis

Screenshot

Using second oldest pre-release:
image

Using current pre-release:
image

Current latest version w/ pre-release notifications disabled:
image

Current latest version w/ pre-release notifications enabled:
image

Old version w/ pre-release notifications disabled:
image

Old version w/ pre-release notifications enabled:
image

Issues Fixed or Closed

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update (updates to dependencies)
  • Documentation update (changes to documentation)
  • Repository update (changes to repository files, e.g. .github/...)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

Branch Updates

LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.

  • I want maintainers to keep my branch updated

@ReenigneArcher ReenigneArcher force-pushed the fix(ui)-ensure-pre-releases-are-properly-checked branch from 70e840b to e90811b Compare May 24, 2024 20:07
Copy link

codecov bot commented May 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 7.03%. Comparing base (c204b2c) to head (965814e).
Report is 161 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #2564    +/-   ##
=======================================
  Coverage    7.03%   7.03%            
=======================================
  Files          87      87            
  Lines       17697   17697            
  Branches     8406    8406            
=======================================
  Hits         1245    1245            
+ Misses      13870   13716   -154     
- Partials     2582    2736   +154     
Flag Coverage Δ
Linux 5.35% <ø> (ø)
Windows 2.56% <ø> (ø)
macOS-12 8.05% <ø> (ø)
macOS-13 7.98% <ø> (ø)
macOS-14 8.27% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 24 files with indirect coverage changes

src_assets/common/assets/web/index.html Outdated Show resolved Hide resolved
@ReenigneArcher ReenigneArcher force-pushed the fix(ui)-ensure-pre-releases-are-properly-checked branch from e90811b to 813112e Compare May 24, 2024 22:42
@ReenigneArcher ReenigneArcher force-pushed the fix(ui)-ensure-pre-releases-are-properly-checked branch from 813112e to 965814e Compare May 24, 2024 22:56
@ReenigneArcher ReenigneArcher merged commit 2b18e4c into master May 25, 2024
49 checks passed
@ReenigneArcher ReenigneArcher deleted the fix(ui)-ensure-pre-releases-are-properly-checked branch May 25, 2024 00:09
@Hazer Hazer mentioned this pull request May 30, 2024
11 tasks
KuleRucket pushed a commit to KuleRucket/Sunshine that referenced this pull request Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants