Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update readthedocs on release events #2604

Merged
merged 1 commit into from
Jun 7, 2024

Conversation

ReenigneArcher
Copy link
Member

@ReenigneArcher ReenigneArcher commented May 29, 2024

Description

We need to change the "default_branch" property in readthedocs in order to make the "latest" version point to our latest stable release.

This workflow will probably become a global workflow and replicated from .github. See: LizardByte/.github#341

Screenshot

Issues Fixed or Closed

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update (updates to dependencies)
  • Documentation update (changes to documentation)
  • Repository update (changes to repository files, e.g. .github/...)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

Branch Updates

LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.

  • I want maintainers to keep my branch updated

@ReenigneArcher ReenigneArcher force-pushed the docs-update-readthedocs-on-release-events branch from bbb8f17 to 0c58830 Compare May 29, 2024 01:28
Copy link

codecov bot commented May 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 7.98%. Comparing base (9afb1ae) to head (4478067).
Report is 166 commits behind head on master.

Additional details and impacted files
@@          Coverage Diff           @@
##           master   #2604   +/-   ##
======================================
  Coverage    7.98%   7.98%           
======================================
  Files          88      88           
  Lines       18039   18039           
  Branches     8596    8596           
======================================
  Hits         1441    1441           
  Misses      13757   13757           
  Partials     2841    2841           
Flag Coverage Δ
Linux 6.05% <ø> (ø)
Windows 3.76% <ø> (ø)
macOS-12 9.03% <ø> (ø)
macOS-13 8.93% <ø> (+0.01%) ⬆️
macOS-14 9.22% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@Hazer
Copy link
Member

Hazer commented May 29, 2024

Looks good to me

@ReenigneArcher ReenigneArcher force-pushed the docs-update-readthedocs-on-release-events branch from 0c58830 to 4478067 Compare June 7, 2024 20:48
@ReenigneArcher ReenigneArcher marked this pull request as ready for review June 7, 2024 20:48
@ReenigneArcher ReenigneArcher merged commit add77d2 into master Jun 7, 2024
47 checks passed
@ReenigneArcher ReenigneArcher deleted the docs-update-readthedocs-on-release-events branch June 7, 2024 21:57
KuleRucket pushed a commit to KuleRucket/Sunshine that referenced this pull request Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants