Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(upnp): support newer miniupnpc library #2782

Merged
merged 1 commit into from
Jul 1, 2024

Conversation

ReenigneArcher
Copy link
Member

Description

Fixes incompatibilities with newer version of miniupnpc library.

Screenshot

Issues Fixed or Closed

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update (updates to dependencies)
  • Documentation update (changes to documentation)
  • Repository update (changes to repository files, e.g. .github/...)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

Branch Updates

LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.

  • I want maintainers to keep my branch updated

@ReenigneArcher ReenigneArcher force-pushed the fix(upnp)-support-newer-miniupnpc-library branch 2 times, most recently from 3bab999 to eb06109 Compare July 1, 2024 00:48
Co-Authored-By: Vithorio Polten <reach@vithor.io>
@ReenigneArcher ReenigneArcher force-pushed the fix(upnp)-support-newer-miniupnpc-library branch from eb06109 to f39b8df Compare July 1, 2024 01:02
Copy link

codecov bot commented Jul 1, 2024

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Project coverage is 8.99%. Comparing base (90fd371) to head (f39b8df).
Report is 136 commits behind head on master.

Files with missing lines Patch % Lines
src/upnp.cpp 0.00% 2 Missing and 2 partials ⚠️
src/upnp.h 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##           master   #2782      +/-   ##
=========================================
+ Coverage    8.95%   8.99%   +0.03%     
=========================================
  Files          94      95       +1     
  Lines       17383   17385       +2     
  Branches     8267    8268       +1     
=========================================
+ Hits         1557    1564       +7     
+ Misses      12962   12957       -5     
  Partials     2864    2864              
Flag Coverage Δ
Linux 6.85% <0.00%> (+0.06%) ⬆️
Windows 4.16% <0.00%> (-0.01%) ⬇️
macOS-12 10.01% <0.00%> (-0.02%) ⬇️
macOS-13 9.92% <0.00%> (-0.01%) ⬇️
macOS-14 10.22% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/upnp.h 0.00% <0.00%> (ø)
src/upnp.cpp 3.01% <0.00%> (ø)

... and 2 files with indirect coverage changes

@ReenigneArcher ReenigneArcher merged commit a940cdb into master Jul 1, 2024
48 of 49 checks passed
@ReenigneArcher ReenigneArcher deleted the fix(upnp)-support-newer-miniupnpc-library branch July 1, 2024 14:07
KuleRucket pushed a commit to KuleRucket/Sunshine that referenced this pull request Oct 9, 2024
Co-authored-by: Vithorio Polten <reach@vithor.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sunshine build fails from AUR on upnp.cpp.o
2 participants