Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(flatpak): add xvfb locally #2797

Merged
merged 1 commit into from
Jul 2, 2024

Conversation

ReenigneArcher
Copy link
Member

Description

xvfb was removed from flatpak's Builder BaseApp in flathub/org.flatpak.Builder.BaseApp@402cd76

Screenshot

Issues Fixed or Closed

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update (updates to dependencies)
  • Documentation update (changes to documentation)
  • Repository update (changes to repository files, e.g. .github/...)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

Branch Updates

LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.

  • I want maintainers to keep my branch updated

Copy link

codecov bot commented Jul 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 8.91%. Comparing base (9b5a046) to head (34ac47c).

Additional details and impacted files
@@            Coverage Diff            @@
##           master   #2797      +/-   ##
=========================================
- Coverage    8.95%   8.91%   -0.04%     
=========================================
  Files          95      95              
  Lines       17386   17379       -7     
  Branches     8268    8268              
=========================================
- Hits         1557    1550       -7     
- Misses      12961   12964       +3     
+ Partials     2868    2865       -3     
Flag Coverage Δ
Linux 6.78% <ø> (ø)
Windows 4.16% <ø> (ø)
macOS-12 ?
macOS-13 9.93% <ø> (+0.01%) ⬆️
macOS-14 10.22% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 5 files with indirect coverage changes

@ReenigneArcher ReenigneArcher force-pushed the build(flatpak)-add-xvfb-locally branch from 9a3cae0 to 34ac47c Compare July 2, 2024 22:10
@ReenigneArcher ReenigneArcher enabled auto-merge (squash) July 2, 2024 22:16
@ReenigneArcher ReenigneArcher merged commit 0b2487d into master Jul 2, 2024
49 checks passed
@ReenigneArcher ReenigneArcher deleted the build(flatpak)-add-xvfb-locally branch July 2, 2024 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant