fix(linux/input): don't pass unknown battery values

[cgutman]

Description

The battery.percentage value is a real percentage (0..100), but it has a special value of LI_BATTERY_PERCENTAGE_UNKNOWN (0xFF) to indicate the percentage is unknown. We shouldn't pass this value or the LI_BATTERY_STATE_UNKNOWN status into inputino.

cc: @ABeltramo

Screenshot

Issues Fixed or Closed

Fixes #2715

Type of Change

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• Dependency update (updates to dependencies)
• Documentation update (changes to documentation)
• Repository update (changes to repository files, e.g. .github/...)

Checklist

• My code follows the style guidelines of this project
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

Branch Updates

LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.

• I want maintainers to keep my branch updated

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 9.23%. Comparing base (d57c66f) to head (a006100).

Additional details and impacted files

@@            Coverage Diff            @@
##           master   #2820      +/-   ##
=========================================
- Coverage    9.24%   9.23%   -0.01%     
=========================================
  Files          97      97              
  Lines       17433   17440       +7     
  Branches     8314    8314              
=========================================
  Hits         1611    1611              
- Misses      12939   12946       +7     
  Partials     2883    2883              

Flag	Coverage Δ
Linux	6.99% <0.00%> (-0.01%)	⬇️
Windows	4.53% <ø> (ø)
macOS-12	10.32% <ø> (ø)
macOS-13	10.23% <ø> (ø)
macOS-14	10.55% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
src/platform/linux/input/inputtino_gamepad.cpp	2.54% <0.00%> (-0.12%)	⬇️

[ABeltramo]

Re-looking at this, we should probably add LI_BATTERY_STATE_NOT_PRESENT and LI_BATTERY_STATE_NOT_CHARGING so that we cover all cases?

case LI_BATTERY_STATE_NOT_CHARGING:
 state = inputtino::PS5Joypad::CHARGHING_ERROR;
 break
case LI_BATTERY_STATE_UNKNOWN:
case LI_BATTERY_STATE_NOT_PRESENT:
  return; // We can't set it, let's return

[cgutman]

LI_BATTERY_STATE_NOT_PRESENT makes sense, but I'm not sure about mapping LI_BATTERY_STATE_NOT_CHARGING to a charging error. We don't really have a specific value in the protocol to indicate that a device is actually broken. "Not charging" could simply indicate the device is holding at 80% or whatever to preserve the life of the battery cells.

[ABeltramo]

Right, makes sense. To be fair I'm not even sure what the actual meaning for CHARGING_ERROR originally is or how (if?) that will be picked up by clients, but I can see the subtle difference that you mention.

[cgutman]

Okay, I changed the logic here to just ignore status values that the code doesn't understand and those that don't have good mappings to inputino.

If there was a way to just report a percentage without a battery status, maybe we could support LI_BATTERY_STATE_NOT_CHARGING.