-
-
Notifications
You must be signed in to change notification settings - Fork 950
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor periodic loggers and limit batch size for small packets #2835
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2835 +/- ##
=========================================
+ Coverage 9.04% 9.12% +0.07%
=========================================
Files 96 97 +1
Lines 17437 17433 -4
Branches 8275 8314 +39
=========================================
+ Hits 1578 1590 +12
- Misses 12972 13020 +48
+ Partials 2887 2823 -64
Flags with carried forward coverage won't be shown. Click here to find out more.
|
So, |
GitHub api was having some issues earlier |
Previously it was limited only by size, and exceeding 64 packets in a single batch is asking for problems.
5ccfe9a
to
68bcd35
Compare
…ardByte#2835) * Refactor periodic loggers * Limit network batch size also by packet count Previously it was limited only by size, and exceeding 64 packets in a single batch is asking for problems.
Description
Refactor recurring code into dedicated classes and address small edge-case I missed in #2803
Screenshot
Issues Fixed or Closed
Type of Change
.github/...
)Checklist
Branch Updates
LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.