Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Escape backslashes in javascript string #2861

Merged
merged 1 commit into from
Jul 15, 2024

Conversation

ns6089
Copy link
Contributor

@ns6089 ns6089 commented Jul 15, 2024

Description

Backslashes were not escaped which caused default value hint for captured display to be incorrect.

Screenshot

2024-07-15 10_27_47-Window
2024-07-15 10_23_31-Window

Issues Fixed or Closed

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update (updates to dependencies)
  • Documentation update (changes to documentation)
  • Repository update (changes to repository files, e.g. .github/...)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

Branch Updates

LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.

  • I want maintainers to keep my branch updated

@ReenigneArcher ReenigneArcher enabled auto-merge (squash) July 15, 2024 14:48
Copy link

codecov bot commented Jul 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 9.23%. Comparing base (e34f446) to head (3ae3bac).

Additional details and impacted files
@@          Coverage Diff           @@
##           master   #2861   +/-   ##
======================================
  Coverage    9.23%   9.23%           
======================================
  Files          97      97           
  Lines       17440   17440           
  Branches     8314    8314           
======================================
  Hits         1611    1611           
  Misses      12946   12946           
  Partials     2883    2883           
Flag Coverage Δ
Linux 6.99% <ø> (ø)
Windows 4.53% <ø> (ø)
macOS-12 10.32% <ø> (-0.02%) ⬇️
macOS-13 10.23% <ø> (ø)
macOS-14 10.55% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@ReenigneArcher ReenigneArcher merged commit aadd6ee into LizardByte:master Jul 15, 2024
47 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants