build(linux): disable GCC 12 Wrestrict warning

[FrogTheFrog]

Description

This is an actual "fix" for #2919 and other places where the warning cannot be resolved easily (https://github.com/FrogTheFrog/Sunshine/actions/runs/10126414768/job/28003050801).

There is a bug for GCC 12 (https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105651) which unfortunately is used by flatpak.
Since we are treating all warnings as errors, such a bogus warning will prevent Sunshine from compiling. In some cases it is impossible to avoid this warning as it happens somewhere outside of Sunshine's code, like GTest:

test_sunshine.dir/unit/test_display_device.cpp.o -c /run/build/sunshine/tests/unit/test_display_device.cpp
In file included from /usr/include/c++/12.2.0/string:40,
                 from /usr/include/c++/12.2.0/bitset:47,
                 from /run/build/sunshine/src/config.h:7,
                 from /run/build/sunshine/tests/unit/test_display_device.cpp:5:
In static member function ‘static constexpr std::char_traits<char>::char_type* std::char_traits<char>::copy(char_type*, const char_type*, std::size_t)’,
    inlined from ‘static constexpr void std::__cxx11::basic_string<_CharT, _Traits, _Alloc>::_S_copy(_CharT*, const _CharT*, size_type) [with _CharT = char; _Traits = std::char_traits<char>; _Alloc = std::allocator<char>]’ at /usr/include/c++/12.2.0/bits/basic_string.h:423:21,
    inlined from ‘constexpr std::__cxx11::basic_string<_CharT, _Traits, _Allocator>& std::__cxx11::basic_string<_CharT, _Traits, _Alloc>::_M_replace(size_type, size_type, const _CharT*, size_type) [with _CharT = char; _Traits = std::char_traits<char>; _Alloc = std::allocator<char>]’ at /usr/include/c++/12.2.0/bits/basic_string.tcc:532:22,
    inlined from ‘constexpr std::__cxx11::basic_string<_CharT, _Traits, _Alloc>& std::__cxx11::basic_string<_CharT, _Traits, _Alloc>::replace(size_type, size_type, const _CharT*, size_type) [with _CharT = char; _Traits = std::char_traits<char>; _Alloc = std::allocator<char>]’ at /usr/include/c++/12.2.0/bits/basic_string.h:2171:19,
    inlined from ‘constexpr std::__cxx11::basic_string<_CharT, _Traits, _Alloc>& std::__cxx11::basic_string<_CharT, _Traits, _Alloc>::replace(size_type, size_type, const _CharT*) [with _CharT = char; _Traits = std::char_traits<char>; _Alloc = std::allocator<char>]’ at /usr/include/c++/12.2.0/bits/basic_string.h:2196:22,
    inlined from ‘std::string testing::internal::CanonicalizeForStdLibVersioning(std::string)’ at /run/build/sunshine/third-party/googletest/googletest/include/gtest/internal/gtest-type-util.h:83:14:
/usr/include/c++/12.2.0/bits/char_traits.h:431:56: error: ‘void* __builtin_memcpy(void*, const void*, long unsigned int)’ accessing 9223372036854775810 or more bytes at offsets [2, 9223372036854775807] and 1 may overlap up to 9223372036854775813 bytes at offset -3 [-Werror=restrict]
  431 |         return static_cast<char_type*>(__builtin_memcpy(__s1, __s2, __n));
      |                                        ~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~
cc1plus: all warnings being treated as errors

In this case, GTest is calling CanonicalizeForStdLibVersioning to pretty print a type name. Even if the function would never reach the "bad code" branch, it still produces a warning and there is no way around it.

Type of Change

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• Dependency update (updates to dependencies)
• Documentation update (changes to documentation)
• Repository update (changes to repository files, e.g. .github/...)

Checklist

• My code follows the style guidelines of this project
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 9.66%. Comparing base (7737d6f) to head (444dfe2).
Report is 135 commits behind head on master.

Additional details and impacted files

@@          Coverage Diff           @@
##           master   #2925   +/-   ##
======================================
  Coverage    9.66%   9.66%           
======================================
  Files          97      97           
  Lines       17556   17556           
  Branches     8230    8230           
======================================
  Hits         1696    1696           
+ Misses      15076   15068    -8     
- Partials      784     792    +8     

Flag	Coverage Δ
Linux	7.16% <ø> (ø)
Windows	5.08% <ø> (ø)
macOS-12	10.29% <ø> (-0.02%)	⬇️
macOS-13	10.20% <ø> (-0.02%)	⬇️
macOS-14	10.52% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 11 files with indirect coverage changes

[ReenigneArcher]

Is this only occurring in the flatpak build?

[FrogTheFrog]

Is this only occurring in the flatpak build?

The warning itself occurs on GCC12 only, which is only used in flatpak, but I have not checked the dockers as they do not run in forks.

[ReenigneArcher]

but I have not checked the dockers as they do not run in forks

They should, but not from your master branch. You'd need to make a PR into the master and replicate how we run things.

[FrogTheFrog]

@ReenigneArcher This bug affects both flatpak and Docker-debian-bookworm