Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests(windows): prefer static libraries #2939

Merged
merged 2 commits into from
Aug 8, 2024

Conversation

ns6089
Copy link
Contributor

@ns6089 ns6089 commented Jul 31, 2024

Resolves a couple of errors specific to msys.

Description

Screenshot

Issues Fixed or Closed

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update (updates to dependencies)
  • Documentation update (changes to documentation)
  • Repository update (changes to repository files, e.g. .github/...)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

@ReenigneArcher ReenigneArcher changed the title Prefer static libraries in test_sunshine on Windows tests(windows): prefer static libraries Jul 31, 2024
@ReenigneArcher ReenigneArcher self-assigned this Jul 31, 2024
Copy link

codecov bot commented Jul 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 9.68%. Comparing base (6d91e68) to head (3cf8381).

Additional details and impacted files
@@          Coverage Diff           @@
##           master   #2939   +/-   ##
======================================
  Coverage    9.68%   9.68%           
======================================
  Files          97      97           
  Lines       17528   17528           
  Branches     8200    8200           
======================================
  Hits         1698    1698           
- Misses      12994   13052   +58     
+ Partials     2836    2778   -58     
Flag Coverage Δ
Linux 7.19% <ø> (ø)
Windows 5.11% <ø> (ø)
macOS-12 10.37% <ø> (+0.01%) ⬆️
macOS-13 10.27% <ø> (ø)
macOS-14 10.58% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 12 files with indirect coverage changes

tests/CMakeLists.txt Outdated Show resolved Hide resolved
ns6089 and others added 2 commits August 8, 2024 13:05
Resolves a couple of errors specific to msys.
Co-authored-by: ReenigneArcher <42013603+ReenigneArcher@users.noreply.github.com>
@ReenigneArcher ReenigneArcher enabled auto-merge (squash) August 8, 2024 17:06
@ReenigneArcher ReenigneArcher merged commit 19250f1 into LizardByte:master Aug 8, 2024
47 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants