Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(linux): fix new lint errors #2953

Merged
merged 1 commit into from
Aug 3, 2024

Conversation

ReenigneArcher
Copy link
Member

Description

Fixes new linting errors caused by:

Screenshot

Issues Fixed or Closed

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update (updates to dependencies)
  • Documentation update (changes to documentation)
  • Repository update (changes to repository files, e.g. .github/...)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

@ReenigneArcher ReenigneArcher changed the title build(cmake): set CMAKE_PROJECT_VERSION from PROJECT_VERSION (#2936) build(linux): fix new lint errors Aug 3, 2024
@ReenigneArcher ReenigneArcher force-pushed the build(linux)-fix-new-lint-errors branch from 1b20601 to b445a85 Compare August 3, 2024 18:43
Copy link

codecov bot commented Aug 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 9.57%. Comparing base (444ca98) to head (70481f0).

Additional details and impacted files
@@          Coverage Diff           @@
##           master   #2953   +/-   ##
======================================
  Coverage    9.57%   9.57%           
======================================
  Files          97      97           
  Lines       17582   17582           
  Branches     8336    8336           
======================================
  Hits         1683    1683           
- Misses      13006   13011    +5     
+ Partials     2893    2888    -5     
Flag Coverage Δ
Linux 6.95% <ø> (ø)
Windows 5.08% <ø> (ø)
macOS-12 10.29% <ø> (ø)
macOS-13 10.20% <ø> (-0.02%) ⬇️
macOS-14 10.52% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 25 files with indirect coverage changes

ReenigneArcher referenced this pull request in Homebrew/brew Aug 3, 2024
- I got bored doing them manually.
- Also now more people can help with letters of the alphabet using `brew style --only=FormulaAuditStrict/Text --fix homebrew/core`.
@ReenigneArcher ReenigneArcher force-pushed the build(linux)-fix-new-lint-errors branch from b445a85 to 70481f0 Compare August 3, 2024 19:22
@ReenigneArcher ReenigneArcher enabled auto-merge (squash) August 3, 2024 19:50
@ReenigneArcher ReenigneArcher merged commit ecc7f2a into master Aug 3, 2024
47 checks passed
@ReenigneArcher ReenigneArcher deleted the build(linux)-fix-new-lint-errors branch August 3, 2024 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant