fix(win/qsv): skip unsupported 4:4:4 codecs

[ns6089]

Description

Skip particular QSV 4:4:4 codecs bypassing ffmpeg.

Screenshot

Issues Fixed or Closed

Type of Change

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• Dependency update (updates to dependencies)
• Documentation update (changes to documentation)
• Repository update (changes to repository files, e.g. .github/...)

Checklist

• My code follows the style guidelines of this project
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

[codecov]

Codecov Report

Attention: Patch coverage is 20.00000% with 20 lines in your changes missing coverage. Please review.

Project coverage is 9.69%. Comparing base (537e3e6) to head (bef8899).
Report is 1 commits behind head on master.

Files	Patch %	Lines
src/video.cpp	15.38%	6 Missing and 5 partials ⚠️
src/video.h	30.00%	5 Missing and 2 partials ⚠️
src/platform/windows/display_vram.cpp	0.00%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff            @@
##           master   #3029      +/-   ##
=========================================
+ Coverage    9.67%   9.69%   +0.01%     
=========================================
  Files         101     101              
  Lines       17898   17913      +15     
  Branches     8365    8376      +11     
=========================================
+ Hits         1732    1736       +4     
- Misses      13295   13306      +11     
  Partials     2871    2871              

Flag	Coverage Δ
Linux	7.31% <21.73%> (+0.02%)	⬆️
Windows	5.06% <0.00%> (-0.01%)	⬇️
macOS-12	10.51% <15.78%> (+0.02%)	⬆️
macOS-13	10.42% <15.78%> (+0.02%)	⬆️
macOS-14	10.73% <15.78%> (+0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
src/platform/windows/display_vram.cpp	1.66% <0.00%> (-0.01%)	⬇️
src/video.h	52.80% <30.00%> (-2.89%)	⬇️
src/video.cpp	27.22% <15.38%> (+0.01%)	⬆️

[cgutman]

We also need to cover the H.264 case above on line 2519.

Edit: Actually, it looks like we're missing a >= 0 check on the return value of validate_config() there. That explains the weird behavior I saw.

[ns6089]

Updated the branch.

One day we should migrate all those int-returning functions to bool. Some fail on 0, some fail on non-0, and both are implicitly convertible.

[sonarcloud]

Quality Gate passed

Issues
3 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud