Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(win/input): fix false warnings about missing ViGEmBus #3097

Merged
merged 1 commit into from
Aug 26, 2024

Conversation

cgutman
Copy link
Collaborator

@cgutman cgutman commented Aug 26, 2024

Description

Invoking platf::supported_gamepads() during static initalization of config_t was leading to misleading warnings in the logs indicating lack of ViGEmBus. We should handle the !input case specially like we do for the inputino implementation.

Screenshot

Issues Fixed or Closed

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update (updates to dependencies)
  • Documentation update (changes to documentation)
  • Repository update (changes to repository files, e.g. .github/...)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

Copy link

codecov bot commented Aug 26, 2024

Codecov Report

Attention: Patch coverage is 42.85714% with 4 lines in your changes missing coverage. Please review.

Project coverage is 9.82%. Comparing base (45265fb) to head (852fc03).
Report is 1 commits behind head on master.

Files Patch % Lines
src/platform/windows/input.cpp 42.85% 2 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##           master   #3097      +/-   ##
=========================================
- Coverage    9.84%   9.82%   -0.02%     
=========================================
  Files         101     101              
  Lines       17969   17971       +2     
  Branches     8393    8394       +1     
=========================================
- Hits         1769    1766       -3     
- Misses      13320   15408    +2088     
+ Partials     2880     797    -2083     
Flag Coverage Δ
Linux 7.26% <ø> (ø)
Windows 5.06% <42.85%> (-0.03%) ⬇️
macOS-12 10.76% <ø> (ø)
macOS-13 10.66% <ø> (-0.03%) ⬇️
macOS-14 10.96% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/platform/common.h 33.33% <ø> (ø)
src/platform/windows/input.cpp 0.66% <42.85%> (-0.41%) ⬇️

... and 32 files with indirect coverage changes

Copy link
Member

@Hazer Hazer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oof, my bad, I missed that.

Copy link

sonarcloud bot commented Aug 26, 2024

@ReenigneArcher ReenigneArcher merged commit 3976b63 into LizardByte:master Aug 26, 2024
51 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants