Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(web): use shared-web #3116

Merged
merged 1 commit into from
Sep 6, 2024
Merged

feat(web): use shared-web #3116

merged 1 commit into from
Sep 6, 2024

Conversation

ReenigneArcher
Copy link
Member

@ReenigneArcher ReenigneArcher commented Sep 1, 2024

Description

This PR does the following:

  • Use shared-web package for discord.js instead of using the online version.
  • Moves vite packages to dev dependencies.
  • Removes bootstrap and fontawesome as they are dependencies of shared-web (reduces dependabot PRs)
  • Removes @popperjs/core as it is unused?

Todo:

  • create a gh-action to handle the gh-pages using webpack (I'm planning to handle this separately)

Screenshot

Issues Fixed or Closed

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update (updates to dependencies)
  • Documentation update (changes to documentation)
  • Repository update (changes to repository files, e.g. .github/...)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

Copy link

codecov bot commented Sep 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 9.70%. Comparing base (cdc2d1b) to head (4931878).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##           master   #3116      +/-   ##
=========================================
- Coverage    9.82%   9.70%   -0.13%     
=========================================
  Files         101      77      -24     
  Lines       17990   14074    -3916     
  Branches     8411    6460    -1951     
=========================================
- Hits         1768    1366     -402     
+ Misses      13339   10088    -3251     
+ Partials     2883    2620     -263     
Flag Coverage Δ
Linux ?
Windows 5.06% <ø> (ø)
macOS-12 10.78% <ø> (+0.02%) ⬆️
macOS-13 10.66% <ø> (ø)
macOS-14 10.96% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 55 files with indirect coverage changes

@ReenigneArcher ReenigneArcher added this to the stable release milestone Sep 1, 2024
@ReenigneArcher ReenigneArcher force-pushed the feat/web/use-shared-web branch 2 times, most recently from a934fe8 to 255cb97 Compare September 1, 2024 20:00
@ReenigneArcher ReenigneArcher mentioned this pull request Sep 3, 2024
10 tasks
Copy link

sonarcloud bot commented Sep 6, 2024

@ReenigneArcher ReenigneArcher marked this pull request as ready for review September 6, 2024 20:21
@ReenigneArcher ReenigneArcher merged commit e33dea7 into master Sep 6, 2024
37 of 38 checks passed
@ReenigneArcher ReenigneArcher deleted the feat/web/use-shared-web branch September 6, 2024 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant