Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(win/cmake): use cmake_path(CONVERT TO_NATIVE_PATH_LIST) #3152

Merged
merged 3 commits into from
Sep 30, 2024

Conversation

ns6089
Copy link
Contributor

@ns6089 ns6089 commented Sep 6, 2024

Description

file(TO_NATIVE_PATH) broke in latest cmake.

At least in the scoop version of cmake-3.30.3 slashes don't get reversed.
cmake_path(CONVERT TO_NATIVE_PATH_LIST) works fine and this seems to be the intended way to do it anyway. "New in version 3.20."

Screenshot

Capture

Issues Fixed or Closed

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update (updates to dependencies)
  • Documentation update (changes to documentation)
  • Repository update (changes to repository files, e.g. .github/...)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

@ReenigneArcher
Copy link
Member

"New in version 3.20."

Currently, we're specifying 3.18 as the minimum required.

cmake_minimum_required(VERSION 3.18)

I'm not sure if it's possible to dynamically set the minimum version, based on the OS or whatever. I'm fine with bumping it though. All our linux builds will compile cmake if it's lower 3.25 right now anyway. Could possibly cause issues for anyone self compiling on older LTS releases.

Copy link

codecov bot commented Sep 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 9.82%. Comparing base (fb712e3) to head (126c775).
Report is 1 commits behind head on master.

Additional details and impacted files
@@          Coverage Diff           @@
##           master   #3152   +/-   ##
======================================
  Coverage    9.82%   9.82%           
======================================
  Files         101     101           
  Lines       17981   17981           
  Branches     8419    8419           
======================================
  Hits         1767    1767           
  Misses      13323   13323           
  Partials     2891    2891           
Flag Coverage Δ
Linux 7.27% <ø> (ø)
Windows 5.10% <ø> (ø)
macOS-13 10.68% <ø> (-0.02%) ⬇️
macOS-14 10.02% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ReenigneArcher ReenigneArcher changed the title fix(win/cmake): file(TO_NATIVE_PATH) broke in latest cmake fix(win/cmake): use cmake_path(CONVERT TO_NATIVE_PATH_LIST) Sep 30, 2024
@ReenigneArcher ReenigneArcher enabled auto-merge (squash) September 30, 2024 21:07
Copy link

sonarcloud bot commented Sep 30, 2024

@ReenigneArcher ReenigneArcher merged commit fa654c1 into LizardByte:master Sep 30, 2024
36 checks passed
KuleRucket pushed a commit to KuleRucket/Sunshine that referenced this pull request Oct 9, 2024
…te#3152)

Co-authored-by: ReenigneArcher <42013603+ReenigneArcher@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants