-
-
Notifications
You must be signed in to change notification settings - Fork 950
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(configure): auto generate open urls #3163
Conversation
94efefc
to
1cc68fc
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3163 +/- ##
=========================================
+ Coverage 9.72% 9.84% +0.11%
=========================================
Files 77 101 +24
Lines 14058 17974 +3916
Branches 6453 8401 +1948
=========================================
+ Hits 1367 1769 +402
- Misses 12028 13324 +1296
- Partials 663 2881 +2218
Flags with carried forward coverage won't be shown. Click here to find out more. |
2b1a228
to
432dffa
Compare
432dffa
to
25e0009
Compare
@cgutman Could you review this? You don't necessarily need to look at the code if you don't want, but I'd like your feedback on the rendered changes. https://lizardbyte--3163.org.readthedocs.build/projects/sunshine/en/3163/md_docs_2configuration.html This also addresses something you brought previously about using |
@@ -629,7 +638,7 @@ editing the `conf` file in a text editor. Use the examples as reference. | |||
</tr> | |||
</table> | |||
|
|||
### [native_pen_touch](https://localhost:47990/config/#native_pen_touch) | |||
### keybindings |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This option isn't available in the UI, but a "Open" button will still be generated.
We should probably add this to the UI instead of excluding the open button from being created just for this case.
@Hazer is this something you can assist with?
Quality Gate passedIssues Measures |
Description
keybindings
Todo:
Screenshot
Preview: https://lizardbyte--3163.org.readthedocs.build/projects/sunshine/en/3163/md_docs_2configuration.html
Issues Fixed or Closed
Type of Change
.github/...
)Checklist