Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Reverse Proxy support #3173

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

fix: Reverse Proxy support #3173

wants to merge 3 commits into from

Conversation

Degot
Copy link

@Degot Degot commented Sep 12, 2024 •
edited by ReenigneArcher
Loading

Description

These changes allow to use sunshine webui after reverse proxy with subpath.

Screenshot

Issues Fixed or Closed

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update (updates to dependencies)
  • Documentation update (changes to documentation)
  • Repository update (changes to repository files, e.g. .github/...)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

@Degot Degot changed the title modified URLs to allow reverse proxy + set base in vite.config Fix Reverse Proxy support Sep 12, 2024
@Degot Degot changed the title Fix Reverse Proxy support fix:Reverse Proxy support Sep 13, 2024
@ReenigneArcher

This comment was marked as resolved.

Sign in to view
@ReenigneArcher ReenigneArcher changed the title fix:Reverse Proxy support fix: Reverse Proxy support Sep 14, 2024
@Degot

This comment was marked as resolved.

Sign in to view
@ReenigneArcher

This comment was marked as resolved.

Sign in to view
@Degot

This comment was marked as resolved.

Sign in to view
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Sep 20, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@B1LL1T3R
Copy link

B1LL1T3R commented Sep 20, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hazer Hazer Awaiting requested review from Hazer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

WebUI can't be used as subpath behind Nginx reverse proxy
3 participants
@Degot @ReenigneArcher @B1LL1T3R