build(cmake): Prioritize vendored includes over system-wide

[jmou]

Description

Sunshine will still compile with the vendored headers, even if the system has its own ffmpeg headers installed.

Issues Fixed or Closed

Fixes #3169.

Type of Change

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• Dependency update (updates to dependencies)
• Documentation update (changes to documentation)
• Repository update (changes to repository files, e.g. .github/...)

Checklist

• My code follows the style guidelines of this project
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

[ReenigneArcher]

Nice, I didn't know about this option. Could you add it to the other locations where we use include_directories as well?

[jmou]

Would it be preferable to set https://cmake.org/cmake/help/latest/variable/CMAKE_INCLUDE_DIRECTORIES_BEFORE.html instead?

[ReenigneArcher]

No, there's only 4 places this would need to be added, which would prevent all packagers from having to add a new CLI arg to their build.

[jmou]

OK, I have updated the other locations. FWIW I think it's harmless but unnecessary on the non-SYSTEM includes, since those should not conflict with system-wide includes anyway.

[sonarcloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 9.72%. Comparing base (c63678d) to head (7a266ca).
Report is 1 commits behind head on master.

Additional details and impacted files

@@          Coverage Diff           @@
##           master   #3182   +/-   ##
======================================
  Coverage    9.71%   9.72%           
======================================
  Files          77      77           
  Lines       14058   14058           
  Branches     6453    6453           
======================================
+ Hits         1366    1367    +1     
  Misses      10073   10073           
+ Partials     2619    2618    -1     

Flag	Coverage Δ
Windows	5.07% <ø> (ø)
macOS-12	10.81% <ø> (+0.01%)	⬆️
macOS-13	10.70% <ø> (+0.01%)	⬆️
macOS-14	10.98% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes