feat(web-ui): replace dropdown menus with checkboxes #3455
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3455 +/- ##
=========================================
- Coverage 11.17% 7.88% -3.29%
=========================================
Files 100 90 -10
Lines 17310 15793 -1517
Branches 8069 7480 -589
=========================================
- Hits 1934 1246 -688
+ Misses 12671 12126 -545
+ Partials 2705 2421 -284
Flags with carried forward coverage won't be shown. Click here to find out more. |
FrogTheFrog
force-pushed
the
checkbox-replacement
branch
from
4bd8cd2 to
59913ab
Compare
FrogTheFrog
force-pushed
the
checkbox-replacement
branch
from
59913ab to
74c99f3
Compare
| </select> | ||
| <div class="mb-3 form-check"> | ||
| <label for="excludeGlobalPrep" class="form-label">{{ $t('apps.global_prep_name') }}<div class="mt-0 form-text">{{ $t('_common.enabled_def_cbox') }}</div></label> | ||
| <input type="checkbox" class="form-check-input" id="excludeGlobalPrep" v-model="editForm['exclude-global-prep-cmd']" true-value="false" false-value="true" /> |
There was a problem hiding this comment.
This should probably be renamed to includeGlobalPrep to simplify the true/false values and avoid confusion. Since the default is enabled/true it doesn't seem to make sense as is.
There was a problem hiding this comment.
It probably should, however this involves more work than just replacing dropdown list with checkbox, which I would like not to do here.
| </select> | ||
| <div class="mb-3 form-check"> | ||
| <label for="install_steam_audio_drivers" class="form-label">{{ $t('config.install_steam_audio_drivers') }}<div class="mt-0 form-text">{{ $t('_common.enabled_def_cbox') }}</div></label> | ||
| <input type="checkbox" class="form-check-input" id="install_steam_audio_drivers" v-model="config.install_steam_audio_drivers" true-value="enabled" false-value="disabled" /> |
There was a problem hiding this comment.
| <input type="checkbox" class="form-check-input" id="install_steam_audio_drivers" v-model="config.install_steam_audio_drivers" true-value="enabled" false-value="disabled" /> | |
| <input | |
| type="checkbox" | |
| class="form-check-input" | |
| id="install_steam_audio_drivers" | |
| v-model="config.install_steam_audio_drivers" | |
| true-value="enabled" | |
| false-value="disabled" | |
| /> |
When the line is too long can we do this?
Also, do the true/false values account for all the possible options in the config? Ideally in the cpp we would translate enabled/disabled to boolean before providing it to the web-ui.
There was a problem hiding this comment.
When the line is too long can we do this?
I'll try to come up with something better.
Also, do the true/false values account for all the possible options in the config? Ideally in the cpp we would translate enabled/disabled to boolean before providing it to the web-ui.
As you have said, only 1 value pair will be accounted for. In case none of the values match, it defaults to false. Again, this requires more refactoring due to separate parsing in cpp/vue. I do not want to do this here.
FrogTheFrog
force-pushed
the
checkbox-replacement
branch
2 times, most recently
from
0274081 to
60d7c1c
Compare
|
Description
Replaced the enabled/disabled dropdowns with checkboxes.
Except this one as it has custom dropdown values and it seems that it could possible have more values in the future:
Additionally fixed incorrectly labeled default values, some missing/mis-configured translation stuff and styling issues.
Screenshots
General
Before
After
Input
Before 1
After 1
Before 2
After 2
Before 3
After 3
Before 4
After 4
Audio/Video
Before
After
Network
Before
After
Nvidia
Before
After
Intel
Before
After
AMD
Before
After
VideoToolbox
Before
After
VA-API
Before
After
Apps
Before
After
Type of Change
.github/...)Checklist