fix(shaders/directx): replace modulus with bitwise operator #3499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace modulo operation with bitwise operation to optimize performance and remove warning messages on some GPUs
FrogTheFrog
approved these changes
Dec 29, 2024
Added comment
ReenigneArcher
changed the title
|
Sorry for the spam, trying to clean this up from GitHub ui. |
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3499 +/- ##
=========================================
- Coverage 7.87% 7.87% -0.01%
=========================================
Files 90 90
Lines 15803 15803
Branches 7487 7487
=========================================
- Hits 1245 1244 -1
- Misses 12131 12133 +2
+ Partials 2427 2426 -1
Flags with carried forward coverage won't be shown. Click here to find out more. |
qiin2333
pushed a commit
to qiin2333/Sunshine-Foundation
that referenced
this pull request
Dec 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace modulo operation with bitwise operation to optimize performance and remove warning messages on some GPUs