Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enabled AC3,EAC3 and SWR #311

Closed
wants to merge 2 commits into from
Closed

Conversation

mariotaku
Copy link

Description

This PR added AC3, EAC3 encoder to FFMPEG, also swresample for converting PCM format from S16LE to FLTP.

While AC3 has a significantly larger samples per frame (1536 vs 240 currently), it's a compromise because this will be the only way to play 5.1 surround on some platforms.

EAC3 has 256 samples per frame, which is slightly larger than 240 we have now.

Screenshot

Issues Fixed or Closed

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update (updates to dependencies)
  • Documentation update (changes to documentation)
  • Repository update (changes to repository files, e.g. .github/...)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

Branch Updates

LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.

  • I want maintainers to keep my branch updated

@mariotaku mariotaku marked this pull request as draft April 12, 2024 08:40
@mariotaku mariotaku force-pushed the master branch 2 times, most recently from 72d2c13 to cc46405 Compare April 12, 2024 10:34
@mariotaku
Copy link
Author

Not needed anymore: LizardByte/Sunshine#2424

@mariotaku mariotaku closed this Apr 16, 2024
@moi952
Copy link

moi952 commented Jun 2, 2024

@mariotaku you think you can add to a production version ? 😀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants