aerospace: fix on-window-detected #1168
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
talhaHavadar
force-pushed
the
fix-aerospace-on-window-detect
branch
from
44a46ea to
0a3df54
Compare
|
Would be nice to land this! Is there anything I can do to help? |
|
actually had no idea how to speed things up, this is my first time contributing this repo. |
NikolayGalkin
approved these changes
Nov 20, 2024
Enzime
requested changes
Dec 2, 2024
| @@ -71,9 +85,17 @@ in | |||
| description = "Default orientation for the root container."; | |||
| }; | |||
| on-window-detected = lib.mkOption { | |||
| type = listOf str; | |||
| type = listOf (attrsOf (either callbackConf (listOf callbackConf))); | |||
There was a problem hiding this comment.
I think it would be better with types.listOf (types.attrsOf types.anything)
Ideally we would be able to type this better, but I'm not familiar with Aerospace
There was a problem hiding this comment.
I think this is cleaner indeed :) just pushed the changes
talhaHavadar
force-pushed
the
fix-aerospace-on-window-detect
branch
from
7f5231c to
8259566
Compare
|
I don't really have any idea how the fix is being managed really :) |
|
@talhaHavadar my bad. I linked the wrong pr by mistake 😓 . Here is the correct pr #1208 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the issue #1142
I am not proficient in nix so I tried to create a sort of generic type, it might be too broad in this case but this fixes the Aerospace crash issue due to incorrect typing.