services/yabai: cleanup and add errorLogFile/outLogFile #1231
Conversation
|
Otherwise this PR looks great to me |
khaneliman
changed the title
| errorLogFile = mkOption { | ||
| type = types.path; | ||
| default = "/var/tmp/yabai.error.log"; | ||
| example = "/Users/khaneliman/Library/Logs/yabai.log"; | ||
| description = "Path to the yabai error log file"; | ||
| }; | ||
|
|
||
| outLogFile = mkOption { | ||
| type = types.path; | ||
| default = "/var/tmp/yabai.out.log"; | ||
| example = "/Users/khaneliman/Library/Logs/yabai.log"; | ||
| description = "Path to the yabai stdout log file"; | ||
| }; |
There was a problem hiding this comment.
Is there a reason you picked /var/tmp over /tmp or /var/log? Upstream just puts them in /tmp, but /var/log (like you did for the scripting additions) also makes sense to me
There was a problem hiding this comment.
User agents dont have access to /var/log but the global daemon does. It would probably be nice to use ~/Library/Logs/ but I believe I couldn't use ~ when testing before.
There was a problem hiding this comment.
That makes sense. What about /tmp instead of /var/tmp? I don't really care either way, I've just never seen /var/tmp used before and didn't actually know that existed
There was a problem hiding this comment.
/tmp could be purged on reboots, /var/tmp wouldn't be. So depends on what you think the default behavior should be.
There was a problem hiding this comment.
Ack sorry something is up with my notifications so I missed this. My personal preference is /tmp because it's what upstream appears to use, I think it's more visible, and I think it's fine if these logs don't persist across a reboot.
That said, I don't have permissions to merge this, so we could leave it up to @Enzime
|
Not gonna comment on the other two PRs but I have the same question about log location |
|
Just chiming in, the default yabai plist (as I'm writing this) can be found here: https://github.com/koekeishiya/yabai/blob/f4ada8d557aeb9c8ba0d031ee6f645acffff50fd/src/misc/service.h#L8-L42 As a user, I think its better to keep most of it as-is, to avoid differences in behavior from a 'normal' yabai installation. However, it would be nice to allow the option to override the launch agent configuration. |
Similar to #840 for allowing one to monitor the application's output in their logs.