Fix active arg parsing #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arg is the string with the value passed for the active effect. Calling bool() on a non-empty string always returns True. As a result calling `razer-cli -e active,0` sets the device as active instead of inactive. This commit fixes that by converting the arg to an integer before calling bool() on it.
|
Thanks! 🙏 |
|
@all-contributors please add @romainrichard for code |
|
I've put up a pull request to add @romainrichard! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
argis the string with the value passed for the active effect. Callingbool()on a non-empty string always returnsTrue. As a result callingrazer-cli -e active,0sets the device as active instead of inactive.This commit fixes that by converting the arg to an integer before calling
bool()on it.