Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove isomorphic-fetch due to vulnerabilities #28

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Remove isomorphic-fetch due to vulnerabilities #28

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
163 changes: 106 additions & 57 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
"dependencies": {
"babel-runtime": "^6.20.0",
"glob": "^7.1.1",
"isomorphic-fetch": "^2.1.1",
"node-fetch": "^2.7.0",
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The v3 version requires ESM, but this one should be fine security-wise.

"yargs": "^5.0.0"
},
"devDependencies": {
Expand Down
9 changes: 8 additions & 1 deletion src/apiClient.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,13 @@
import 'isomorphic-fetch';
import nodeFetch from 'node-fetch';
import { version as cliVersion } from '../package.json';

if (!global.fetch) {
global.fetch = module.exports;
global.Response = nodeFetch.Response;
global.Headers = nodeFetch.Headers;
global.Request = nodeFetch.Request;
}

Comment on lines +4 to +10
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is just what isomorphic-fetch does on commonjs. Perhaps it could be hidden somehow, it feels kind of nasty out here.

Alternatively, the fetch implementation could be injected from outside, but it was overall a bigger change code and architecture-wise.

const delay = t => new Promise(resolve => setTimeout(resolve, t));

const RETRY_STATUS = [429, 500, 502, 503, 504];
Expand Down