Fix of JMF format entity writer #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r every entity, that has solid brush in any child recursive hierarchy Added solid brush entity to 121v map file for tests
|
This might take me a little while to verify since I'll need to work out how JMF works again... In the meantime, you might be interested to know that the free version of JACK was updated recently and it supports the v122 format and crashes less often :) |
|
K, thanks, will wait for next update. |
|
Sorry for the delay on this one, the proposed fix only partially worked as it didn't handle when there are groups inside entities (not supported for JMF format but is allowed in RMF). Hopefully the updated fix works as expected. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If map has solid brush entities - writer collects every solid brush recursively in its child hierarchy.
Added solid brush entity to 121v map file for tests.
Cant open 122v jmf map file, so you might want to add entity to fix tests.