Editorial: fix highlighting van openyaml specificatie #159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Door expliciet yaml als language te specificeren moet de higlighting nu wel goed gaan. Fixes Geonovum/KP-APIs#643
Het moet zonder prefix `language-`, in tegenstelling tot de documentatie op de highlightjs website.
sanderke
reviewed
Jan 20, 2025
|
Zojuist ook gecheckt dat deze PR ook Geonovum/KP-APIs#642 oplost. Dit zijn alle contrast issues op Al deze zijn niet meer te zien op deze branch. Let wel: hiervoor moet de browser in darkmode staan. Alle URLs hebben dan geen color highlighting, terwijl de yaml code snippet dat wel heeft:
|
Die zijn in strijd met /core/no-trailing-slash
sanderke
reviewed
Jan 22, 2025
There was a problem hiding this comment.
De regel /core/no-trailing-slash slaat enkel op resources. Dit dient nog verduidelijkt te worden:
Verder niets mis met het verwijderen van de trailing slashes in deze voorbeelden, echter is er eentje blijven plakken:
API-Design-Rules/DesignRules.md
Line 545 in bffc439
sanderke
approved these changes
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Door expliciet yaml als language te specificeren moet
de higlighting nu wel goed gaan.
Fixes Geonovum/KP-APIs#632
Fixes Geonovum/KP-APIs#642
Fixes Geonovum/KP-APIs#643