WIP/proof-of-concept: refactor Box/Rc/Arc to reduce code duplication.
#134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cast_slice error precedence changed, so attempting to cast an unaligned *and* slop-ful slice will now return OutputSliceWouldHaveSlop instead of TargetAlignmentGreaterAndInputNotAligned. The documentation of try_cast_slice doesn't *explicitly* say which error will be returned if multiple occur, so this might just be fine as a behavior change.
zachs18
force-pushed
the
wip_refactor_alloc
branch
from
f766786
to
a5b1bd5
Compare
|
Rebased, but I think I'm going to close this because:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP/proof-of-concept: As mentioned in #132, much of the code for
Box/Rc/Arc's functions is very similar. This WIP does not address the public API duplication mentioned in that PR and #133, but it does somewhat address the code duplication by factoring out the common code into generictry_cast_aligned_ptrandtry_cast_aligned_slice_ptrfunctions, which use a traitCastablePointerto convert between smart pointer types and raw pointers.The API is the same as #132 and is all implemented, but there are some "TODO"s in the code of things that could be added or things that could be removed.
Currently, the only changes are private, but something similar this could perhaps be made public.
Alternately to how it currrently works, the
CastablePointer<T>trait could instead be parameterized on the "raw" type it returns, (rather than being hardcoded to have a "raw" type of*mut T). This could make it possible to additionally use it forVec, though I don't know how useful that would be, sinceVecneeds some special handling anyway.