Improve fill_zeroes' use of ptr::write_bytes
#284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like these are deliberately two lines to prevent the length check (using |
|
Nice catch! It doesn't seem to annoy MIRI though: https://play.rust-lang.org/?edition=2021&gist=3ffc5bffdb51903f2613413470953084 |
a1phyr
force-pushed
the
improve_fill_zeroes
branch
from
d4fc770 to
002072f
Compare
Lokathor
approved these changes
Nov 19, 2024
Lokathor
added
not yet released
semver-patch
|
released in bytemuck-1.20 |
|
I think the old version filled padding with zeroes, but the new one isn't guaranteed to. |
https://doc.rust-lang.org/core/ptr/fn.write_bytes.html and the size of T includes any tail padding so i think this is the same? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.