Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OSOE-523: Optimize spell-checking dictionary files across projects #397

Merged
merged 73 commits into from
Feb 23, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
73 commits
Select commit Hold shift + click to select a range
80d2ca9
Updating LGHA to issue branch
BenedekFarkas Feb 7, 2023
d82e085
Updating build-and-test workflow to use the issue branch of LGHA
BenedekFarkas Feb 7, 2023
0f67779
Temporarily disabling build and code analysis steps in the build-and-…
BenedekFarkas Feb 7, 2023
12d43fa
Updating LGHA to latest dev
BenedekFarkas Feb 8, 2023
76d0d3b
Merge remote-tracking branch 'origin/dev' into issue/OSOE-523
BenedekFarkas Feb 8, 2023
21ca03c
Updating LGHA with parameterization changes and testing OSOCE spell c…
BenedekFarkas Feb 9, 2023
49059ae
Adding html spell checking dictionary
BenedekFarkas Feb 9, 2023
aaad3d4
Adding npm spell checking dictionary
BenedekFarkas Feb 9, 2023
18565ec
Adding fullstack spell checking dictionary
BenedekFarkas Feb 9, 2023
2559a4c
Adding css spell checking dictionary
BenedekFarkas Feb 9, 2023
c854a2b
Updating LGHA
BenedekFarkas Feb 9, 2023
d23c454
Updating submodules and spelling configuration
BenedekFarkas Feb 9, 2023
73e2bc6
Updating spelling dictionary list in the build-and-test workflow
BenedekFarkas Feb 9, 2023
c29eb73
Fixing dictionary list in the build-and-test workflow
BenedekFarkas Feb 9, 2023
822e017
Moving spelling configuration files to the correct subfolder
BenedekFarkas Feb 9, 2023
6967b9f
Updating submodules and OSOCE.txt dictionary file
BenedekFarkas Feb 9, 2023
7627f4e
Updating submodules
BenedekFarkas Feb 9, 2023
ffb618b
Adding spell checking ignore pattern to ignore a whole code block
BenedekFarkas Feb 9, 2023
ec590d6
Updating code block ignore pattern
BenedekFarkas Feb 9, 2023
c13c757
Testing alternate pattern for the spell-check ignore code block pattern
BenedekFarkas Feb 10, 2023
eb3d028
Couldn't get the code block ignore pattern working, just excluding Co…
BenedekFarkas Feb 10, 2023
396de35
Updating LGHA with test code
BenedekFarkas Feb 10, 2023
67256bf
Updating LGHA again
BenedekFarkas Feb 10, 2023
da40072
Testing excludes.txt and patterns.txt merging logic
BenedekFarkas Feb 10, 2023
dd2440c
Updating LGHA with script improvements
BenedekFarkas Feb 10, 2023
763ccb5
Updating LGHA with dictionary list merging fixed
BenedekFarkas Feb 10, 2023
177d8d9
Updating LGHA
BenedekFarkas Feb 10, 2023
89cbda4
Updating LGHA
BenedekFarkas Feb 10, 2023
8d8648b
Moving allow/OSOCE.txt to allow.txt
BenedekFarkas Feb 10, 2023
ea93ec8
Testing not using the cpp.txt dictionary
BenedekFarkas Feb 10, 2023
deffd9c
Adding node.txt dictionary
BenedekFarkas Feb 10, 2023
a12189a
Updating submodules
BenedekFarkas Feb 10, 2023
3051bba
Updating LGHA
BenedekFarkas Feb 10, 2023
19735ce
Updating LGHA
BenedekFarkas Feb 10, 2023
209f0ea
Updating LGHA
BenedekFarkas Feb 14, 2023
49aa494
Updating submodules
BenedekFarkas Feb 14, 2023
07fd1b7
Merge branch 'dev' into issue/OSOE-523
BenedekFarkas Feb 14, 2023
c742a7b
Updating LGHA
BenedekFarkas Feb 14, 2023
f516412
Updating LGHA and fixing "advice"
BenedekFarkas Feb 15, 2023
b501021
Updating LGHA
BenedekFarkas Feb 15, 2023
02f3c76
Updating LGHA
BenedekFarkas Feb 15, 2023
37114bd
Merge remote-tracking branch 'origin/dev' into issue/OSOE-523
BenedekFarkas Feb 15, 2023
1461b90
Updating LGHA
BenedekFarkas Feb 15, 2023
3f9e5cb
Breaking the law, breaking the law
BenedekFarkas Feb 15, 2023
624549c
Updating LGHA
BenedekFarkas Feb 15, 2023
3ac13b8
Spell-checking test
BenedekFarkas Feb 15, 2023
7ca8250
Revert "Spell-checking test"
BenedekFarkas Feb 15, 2023
f9ec282
Updating LGHA
BenedekFarkas Feb 16, 2023
5999378
Re-enabling solution builds and PS analysis
BenedekFarkas Feb 16, 2023
b079895
Updating PS analysis to use the issue branch version
BenedekFarkas Feb 16, 2023
d56df42
Updating submodules
BenedekFarkas Feb 16, 2023
21d7af9
Merge remote-tracking branch 'origin/dev' into issue/OSOE-523
BenedekFarkas Feb 16, 2023
c67bca2
Updating UITT
BenedekFarkas Feb 16, 2023
dc0d15c
Updating LGHA with merge from dev
BenedekFarkas Feb 17, 2023
3d35f9a
Merge remote-tracking branch 'origin/dev' into issue/OSOE-523
BenedekFarkas Feb 17, 2023
28fe684
Removing local advice.md and updating LGHA with additional step to co…
BenedekFarkas Feb 17, 2023
de5db93
Adding spell-checking configuration files to solution
BenedekFarkas Feb 17, 2023
c1087eb
Updating LGHA
BenedekFarkas Feb 17, 2023
ddc0a82
Updating LGHA with merge from dev
BenedekFarkas Feb 20, 2023
7055c7e
Merge remote-tracking branch 'origin/dev' into issue/OSOE-523
BenedekFarkas Feb 20, 2023
58293e0
Updating LGHA
BenedekFarkas Feb 22, 2023
15bbf46
Temporarily disabling builds
BenedekFarkas Feb 22, 2023
ea64c73
Fixing the list of additional spelling dictionaries
BenedekFarkas Feb 22, 2023
f62a92d
Removing Liquid.txt from the list of additional dictionaries to check…
BenedekFarkas Feb 22, 2023
3f2fa81
Restoring build execution and the usage of the Liquid dictionary
BenedekFarkas Feb 22, 2023
430af0c
Splitting out non-English word entries from allow.txt into expect.txt
BenedekFarkas Feb 22, 2023
91e2982
Updating submodules
BenedekFarkas Feb 22, 2023
b609b0e
Updating LGHA
BenedekFarkas Feb 22, 2023
d54b1d7
Merge remote-tracking branch 'origin/dev' into issue/OSOE-523
BenedekFarkas Feb 22, 2023
98821de
Updating submodules
BenedekFarkas Feb 23, 2023
b9c45c8
Merge remote-tracking branch 'origin/dev' into issue/OSOE-523
BenedekFarkas Feb 23, 2023
609afd4
Updating submodules with issue branch merged to dev
BenedekFarkas Feb 23, 2023
eb38287
Restoring workflow branch references to dev
BenedekFarkas Feb 23, 2023
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions .github/actions/spelling/allow.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
activatable
autorun
chainable
flyout
hackish
hashable
parallelizable
retriable
sanitizers
scrollbars
shortcutting
sudoing
Timestamped
Toolset
uncached
unclickable
5 changes: 5 additions & 0 deletions .github/actions/spelling/excludes.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
test/Lombiq\.UITestingToolbox/Lombiq\.Tests\.UI/Constants/CommonDisplayResolutions\.cs
Piedone marked this conversation as resolved.
Show resolved Hide resolved
tools/Lombiq.GitHub.Actions/
UnmanagedNodeModules/
UploadingTestFileDOCX\.docx$
UploadingTestFileXLSX\.xlsx$
68 changes: 68 additions & 0 deletions .github/actions/spelling/expect.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1,68 @@
autoinit
basethemesample
Bubl
chartjs
Chro
chromedriver
codeanalysis
codestyle
Codeuctivity
colorpicker
contentitemid
copyfiles
createstate
datalabels
datatables
dddd
Demystifier
Embedd
endgroup
executesql
ffff
geckodriver
Giraudel
hsva
htmlvalidate
icbin
JMES
jsoneditor
jsoneditoronline
lastgremlinsclick
linebreak
lintrc
listheader
logtest
lombiqdt
mcr
mde
mediatheme
MHTML
mogwais
mso
Noda
npmrc
omnisharp
onspecial
pickr
PII
popstate
Portainer
postclean
prebuild
rnwood
rolename
sfc
SFCs
smtpport
Subresource
taxonomyfield
testid
textlint
Tful
trainingdemo
tundora
visualstudioextension
vuejs
XDG
xsessionrc
Yarp
12 changes: 9 additions & 3 deletions .github/workflows/build-and-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -44,9 +44,15 @@ jobs:
name: Spelling
uses: Lombiq/GitHub-Actions/.github/workflows/spelling.yml@dev
with:
# While this is the same as the default usually, it's here to allow you to easily change the branch specifier to
# an issue branch if you adjust the dictionaries.
spell-check-this: Lombiq/GitHub-Actions@dev
additional-dictionaries: |
cspell:csharp/csharp.txt
cspell:css/css.txt
cspell:fullstack/fullstack.txt
cspell:html/html.txt
cspell:node/node.txt
cspell:npm/npm.txt
lombiq-lgha:dictionaries/Liquid.txt
lombiq-lgha:dictionaries/Lombiq.people.txt

powershell-static-code-analysis:
name: PowerShell Static Code Analysis
Expand Down
10 changes: 10 additions & 0 deletions Lombiq.OSOCE.sln
Original file line number Diff line number Diff line change
Expand Up @@ -178,6 +178,14 @@ Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "Lombiq.Hosting.BuildVersion
EndProject
Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "Lombiq.Hosting.BuildVersionDisplay.Tests.UI", "src\Modules\Lombiq.Hosting.BuildVersionDisplay\Lombiq.Hosting.BuildVersionDisplay.Tests.UI\Lombiq.Hosting.BuildVersionDisplay.Tests.UI.csproj", "{B261E437-D773-49A7-AA4B-72CFE7A8DE35}"
EndProject
Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "actions", "actions", "{A48B16D8-61C2-4EAD-978E-5DD77121CFA1}"
EndProject
Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "spelling", "spelling", "{106B5DDD-D775-4D25-BE16-4569226620E0}"
ProjectSection(SolutionItems) = preProject
.github\actions\spelling\allow.txt = .github\actions\spelling\allow.txt
.github\actions\spelling\excludes.txt = .github\actions\spelling\excludes.txt
EndProjectSection
EndProject
Global
GlobalSection(SolutionConfigurationPlatforms) = preSolution
Debug|Any CPU = Debug|Any CPU
Expand Down Expand Up @@ -1046,6 +1054,8 @@ Global
{2CA7508D-9E99-4B89-84A9-8F38C860BA76} = {BF1EDFA5-0129-416C-B9ED-8CE68A3FD526}
{8D054C07-A74B-4A37-B407-ED7BFE7C077B} = {11E06A11-1733-408D-BB2F-BFA07075F812}
{B261E437-D773-49A7-AA4B-72CFE7A8DE35} = {6ED7E28F-0556-471C-8AD1-5BB0941411DD}
{A48B16D8-61C2-4EAD-978E-5DD77121CFA1} = {719F19E1-0B20-490C-B325-74E5FD6C838C}
{106B5DDD-D775-4D25-BE16-4569226620E0} = {A48B16D8-61C2-4EAD-978E-5DD77121CFA1}
EndGlobalSection
GlobalSection(ExtensibilityGlobals) = postSolution
SolutionGuid = {C6926E60-1F5A-4B05-B835-B1021FBE07C5}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,12 +14,13 @@ public class SourceLinkTestController : Controller
public async Task<string> Index()
{
// If you step into this call from a debugger session you can check if Source Link works and symbols have been
// loaded. You should be able to step into the original source. For this to work, you'll need to untick "Enable
// loaded. You should be able to step into the original source. For this to work, you'll need to uncheck "Enable
// Just My Code" in Visual Studio settings under Tools -> Options -> Debugging -> General and make sure "Enable
// Source Link support" is checked. For more info see:
// https://devblogs.microsoft.com/dotnet/improving-debug-time-productivity-with-source-link/#enabling-source-link.
// Let symbol loading finish, which might take several minutes (though you can speed it up by just loading
// symbols for "Lombiq.HelpfulLibraries.OrchardCore.dll" under Debugging -> Symbols -> Load only specified modules).
// symbols for "Lombiq.HelpfulLibraries.OrchardCore.dll" under Debugging -> Symbols -> Load only specified
// modules).
var adminUser = await _cachingUserManager.GetUserByNameAsync("admin");
return adminUser?.UserName ?? "No user found.";
}
Expand Down