Reverse names for S3 sort #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LoneRifle
force-pushed
the
base36-filenames
branch
2 times, most recently
from
e639b2d to
f7ed1ca
Compare
LoneRifle
requested changes
Feb 3, 2023
There was a problem hiding this comment.
unit tests are broken due to Babel transforming the BigInt exponentiation operator to Math.pow, which is incompatible with most BigInt implementations in Node. Consider either avoiding BigInts altogether, or somehow reworking babel.config.cjs so that it knows to avoid the use of the offending Babel plugin.
Thanks, I'll run the tests and work through that |
rrmckinley
force-pushed
the
base36-filenames
branch
from
f7ed1ca to
d4cbe6c
Compare
rrmckinley
force-pushed
the
base36-filenames
branch
from
d4cbe6c to
e259898
Compare
|
I removed base 36 usage to focus only on correct behavior for the filename reversal. I have not yet run tests. I see that it uses docker and I'll test that when I have time to configure that setup. I'll let you know when I'm able to run tests. |
rrmckinley
changed the title
LoneRifle
approved these changes
Feb 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use base 36 filenames, reverse names for S3 sort
Fyi, this does not seek to fix likely pagination problems with delete