-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: type issues by using correct import #111
Merged
doprz
merged 8 commits into
Longhorn-Developers:hackathon
from
DhruvArora-03:fix/Status-to-StatusType
Feb 28, 2024
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
00dd63d
fix: use StatusType
DhruvArora-03 86572ea
fix: use AutoLoadStatus
DhruvArora-03 ae518db
fix: use typof SiteSupport.*
DhruvArora-03 77a76d7
fix: one more of Status to StatusType
DhruvArora-03 27fee47
fix: use import type
DhruvArora-03 ea9bf3c
fix: use path alias imports
DhruvArora-03 f6aa80d
fix: use Extract
DhruvArora-03 9230346
fix: remove unnecessary import
DhruvArora-03 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,23 +1,22 @@ | ||
import type { Course, ScrapedRow } from '@shared/types/Course'; | ||
import React, { useEffect, useState } from 'react'; | ||
|
||
import { useKeyPress } from '../hooks/useKeyPress'; | ||
import useSchedules from '../hooks/useSchedules'; | ||
import { CourseCatalogScraper } from '../lib/CourseCatalogScraper'; | ||
import getCourseTableRows from '../lib/getCourseTableRows'; | ||
import type { SiteSupport } from '../lib/getSiteSupport'; | ||
import { populateSearchInputs } from '../lib/populateSearchInputs'; | ||
import ExtensionRoot from './common/ExtensionRoot/ExtensionRoot'; | ||
import AutoLoad from './injected/AutoLoad/AutoLoad'; | ||
import CourseCatalogInjectedPopup from './injected/CourseCatalogInjectedPopup/CourseCatalogInjectedPopup'; | ||
import CoursePopup from './injected/CoursePopupOld/CoursePopup'; | ||
import RecruitmentBanner from './injected/RecruitmentBanner/RecruitmentBanner'; | ||
import TableHead from './injected/TableHead'; | ||
import TableRow from './injected/TableRow/TableRow'; | ||
import TableSubheading from './injected/TableSubheading/TableSubheading'; | ||
import AutoLoad from '@views/components/injected/AutoLoad/AutoLoad'; | ||
import CourseCatalogInjectedPopup from '@views/components/injected/CourseCatalogInjectedPopup/CourseCatalogInjectedPopup'; | ||
import RecruitmentBanner from '@views/components/injected/RecruitmentBanner/RecruitmentBanner'; | ||
import TableHead from '@views/components/injected/TableHead'; | ||
import TableRow from '@views/components/injected/TableRow/TableRow'; | ||
import TableSubheading from '@views/components/injected/TableSubheading/TableSubheading'; | ||
import { useKeyPress } from '@views/hooks/useKeyPress'; | ||
import useSchedules from '@views/hooks/useSchedules'; | ||
import { CourseCatalogScraper } from '@views/lib/CourseCatalogScraper'; | ||
import getCourseTableRows from '@views/lib/getCourseTableRows'; | ||
import type { SiteSupportType } from '@views/lib/getSiteSupport'; | ||
import { populateSearchInputs } from '@views/lib/populateSearchInputs'; | ||
import ExtensionRoot from '@views/components/common/ExtensionRoot/ExtensionRoot'; | ||
|
||
interface Props { | ||
support: SiteSupport.COURSE_CATALOG_DETAILS | SiteSupport.COURSE_CATALOG_LIST; | ||
support: Extract<SiteSupportType, 'COURSE_CATALOG_DETAILS' | 'COURSE_CATALOG_LIST'>; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Nice! |
||
} | ||
|
||
/** | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job, this is much cleaner.